[mosh-devel] Status of two submitted patches

[Jérémie Courrèges-Anglas]

Keith Winstein <keithw at mit.edu> writes:

> Hello Jeremie,

Hi,

> These both look good. Could you please add a Signed-off-by:, and
> ideally file them as a pull request on github.com/keithw/mosh ?

OK for Signed-off-by...

> If you can't do a github pull request, that's ok, but it's easiest for us.

... but please pull from git://git.wxcvbn.org/mosh.git - branch
openbsd-build-fixes - as I don't have a github account.

> Keegan: Can you weigh in here on whether we depend on pselect()'s
> atomicity and whether this usage here is ok in practice?

If the code in the client or the server had called select with an
infinite timeout, then I would have worried a bit more.

A correct but more portable alternative would be the "self-pipe" trick.

http://cr.yp.to/docs/selfpipe.html

-- 
Jérémie Courrèges-Anglas
PGP Fingerprint: 61DB D9A0 00A4 67CF 2A90  8961 6191 8FBF 06A1 1494
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/mosh-devel/attachments/20130416/978fa745/attachment.bin