krb5 commit: Modernize UTF-8/UCS-2 conversion code

[Greg Hudson]

On 04/17/2017 03:24 PM, Stefan Metzmacher wrote:
> is there a reson why you still limit this to USC-2 and not use full UTF16
> support?

This commit was just trying to eliminate warnings, not change the
functionality.

This code originally came from OpenLDAP's utf-8-conv.c, and was
incorporated with the goal of Windows compatibility (for PACs and RC4
string-to-key).  If Windows now supports UTF-16 then we could consider
extending it, but I wouldn't want to do so without confirmation of that.

> We had a lot of trouble with the limited unicode support of krb5 libraries
> in Samba recently, see https://bugzilla.samba.org/show_bug.cgi?id=12262

Thanks for the pointer.