krb5 commit: Modernize UTF-8/UCS-2 conversion code

[Andrew Bartlett]

On Mon, 2017-04-17 at 15:53 -0400, Greg Hudson wrote:
> On 04/17/2017 03:24 PM, Stefan Metzmacher wrote:
> > is there a reson why you still limit this to USC-2 and not use full
> > UTF16
> > support?
> 
> This commit was just trying to eliminate warnings, not change the
> functionality.
> 
> This code originally came from OpenLDAP's utf-8-conv.c, and was
> incorporated with the goal of Windows compatibility (for PACs and RC4
> string-to-key).  If Windows now supports UTF-16 then we could
> consider
> extending it, but I wouldn't want to do so without confirmation of
> that.

Windows has been UTF-16 for quite a long time now.

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba