RFC: libverto nearing release

Nathaniel McCallum npmccallum at redhat.com
Thu Jul 7 17:14:54 EDT 2011


On Thu, 2011-06-30 at 22:29 -0400, Ezra Peisach wrote:
> On an integration front you should use AM_INIT_AUTOMAKE with the 
> automake version you require. AM_SILENT_RULES was not introduced until I 
> believe 1.11...  If I create a dist on a newer machine - it compiles on 
> centos 5 - and passes tests - but that has automake 1.9.6.... and cannot 
> generate configure scripts.

Fixed.

> Also - your .pc files will not work - you substitute prefix, but libdir 
> get defined in terms on exec_prefix - so that should be added.

I'm not quite sure what you mean here. Can you provide a patch?

> The build tests will not work without shared libraries.  The abi test - 
> which should work on a static lib - fails - as you are looking for the 
> .so shared library.

Patches welcome. :)

> In addition  objdump is not universal. nm might be 
> more appropriate - as I believe all unix type platforms have it (I might 
> be wrong here)

Fixed.

> Your configure script says LIBRARIES TO BE BUILT with "yes" next to 
> them. Those that do not should say "no" - currently blank. (configure 
> invoked with no arguments)

Fixed by your patch.

> The timeout test fails on fedora 14 - i386: module glib - time is out of 
> bounds - but this is glib < 2.29 - the test should say not supported...

Fixed by your patch.

Nathaniel




More information about the krbdev mailing list