[ecco-support] [EXTERNAL] Potential errors in ecco-v4-py python package

[Timothy Andrew Smith]

Hey Shengzhe,

Sounds good, the bug is fixed in the master branch of the code. Thanks
again and enjoy your vacation!

Cheers,
Tim

-------------------------------------------------------------------------------------
Tim Smith
PhD Candidate & Graduate Research Assistant
The Oden Institute for Computational Engineering and Sciences
The University of Texas at Austin


On Sat, Aug 3, 2019 at 6:24 AM Chen, Shengzhe <schen26 at albany.edu> wrote:

> Hi Prof. Smith, Fenton and Wang,
> I am on vacation this week and I’m not familiar with the git fork yet.
> And yes, all I did was change * to + and the results look pretty good to
> me.
> It doesn’t really matter if I am the one to make the modification. It’s
> all good as long as the codes got fixed. Thank you all for the suggestion
> and kindness. I will be using the Ecco data and dig further for my research
> so I would like to keep in touch. Thank you again for the tutorial
> materials online which is extremely helpful to me!
> Best,
> Shengzhe
>
> Get Outlook for iOS <https://aka.ms/o0ukef>
> ------------------------------
> *From:* Timothy Andrew Smith <timsmith204 at utexas.edu>
> *Sent:* Friday, August 2, 2019 8:12:43 AM
> *To:* Fenty, Ian G (US 329C) <ian.fenty at jpl.nasa.gov>; Chen, Shengzhe <
> schen26 at albany.edu>
> *Cc:* ECCO support list, wider membership <ecco-support at mit.edu>; Wang,
> Ou (US 329B) <ou.wang at jpl.nasa.gov>
> *Subject:* Re: [EXTERNAL] [ecco-support] Potential errors in ecco-v4-py
> python package
>
> Hey Shengze,
>
> Thank you for the feedback and good catch! This looks like a pretty small
> (but consequential!) typo on a script that I had added.
>
> It looks like the fix is as simple as *->+ in those few lines of the
> functions calc_section_heat_trsp and calc_section_salt_trsp (within
> calc_section_trsp.py).
>
> I would be happy to do this, but as Ian said, if you are familiar or
> comfortable with submitting a pull request
> <https://help.github.com/en/articles/creating-a-pull-request-from-a-fork> from
> a forked <https://help.github.com/en/articles/fork-a-repo> version of
> ECCOv4-py <https://github.com/ECCO-GROUP/ECCOv4-py> with the code changes
> then this would be ideal because it will attribute the fix to you. If
> you're unfamiliar and need some pointers, don't hesitate to contact me -
> I'm happy to help. Let me know what you want to do here.
>
> Cheers,
> Tim
>
> On Thu, Aug 1, 2019 at 22:02 Fenty, Ian G (US 329C) <
> ian.fenty at jpl.nasa.gov> wrote:
>
>> Dear Shengzhe,
>>
>>
>>
>> Thank you for identifying the bug in cal_section_trsp and telling us
>> about it.  Would you mind please sending the code with the bug fix to
>> ian.fenty at jpl.nasa.gov and Ou.Wang at jpl.nasa.gov.  One of us will make
>> sure that the code is fixed and that you are given credit!
>>
>>
>>
>> Of course, if you are familiar with github, you can propose the code
>> change yourself.  Here is the python package repository:
>> https://github.com/ECCO-GROUP/ECCOv4-py
>>
>>
>>
>> -Ian
>>
>>
>>
>>
>>
>> *From: *<ecco-support-bounces at mit.edu> on behalf of "Chen, Shengzhe" <
>> schen26 at albany.edu>
>> *Reply-To: *"ECCO support list, wider membership" <ecco-support at mit.edu>
>> *Date: *Tuesday, July 23, 2019 at 5:58 PM
>> *To: *"ecco-support at mit.edu" <ecco-support at mit.edu>
>> *Subject: *[EXTERNAL] [ecco-support] Potential errors in ecco-v4-py
>> python package
>>
>>
>>
>> Hi there,
>>
>> This is Shengzhe Chen, 3rd-year graduate student from UAlbany. Thanks to
>> Dr. Ian Fenty, I am able to learn from the python packages to process
>> ECCOv4 data.
>>
>>
>>
>> Recently I was trying to use cal_section_trsp to calculate the salt and
>> heat transport through some straits in the Arctic. I found that the results
>> are very different from the observation data (e.g. mooring data) in terms
>> of magnitude. The observation data often show heat transport in the
>> magnitude of TW, where the results generated by ECCOv4 show magnitude of
>> hundreds of TW (PW to TW was done). I then went through
>> the cal_section_trsp codes and compare them with gcmfaces Matlab codes
>> written by Dr. Gael Forget. I found that in heat transport and salt
>> transport part of ECCO-v4-py, a Multiplication sign instead of a plus sign
>> is assigned to combine the advective flux of potential temperature (e.g.
>> ADVx_TH) and diffusive flux of potential temperature (e.g. DFxE_TH).
>>
>> After I changed the sign from multiplication to plus, the results look
>> more similar to observation data.
>>
>>
>>
>> Thank you again for the great work of Python package which helps me a lot
>> to take advantage of ECCOv4 data.
>>
>>
>>
>> Best,
>>
>> Shengzhe
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.mit.edu/pipermail/ecco-support/attachments/20190805/ebcad145/attachment.html