<div dir="ltr">Hey Shengzhe,<div><br></div><div>Sounds good, the bug is fixed in the master branch of the code. Thanks again and enjoy your vacation! </div><div><br></div><div>Cheers,</div><div>Tim </div><div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>-------------------------------------------------------------------------------------</div><div>Tim Smith</div><div>PhD Candidate & Graduate Research Assistant<br></div><div>The Oden Institute for Computational Engineering and Sciences</div><div>The University of Texas at Austin<br></div></div></div></div></div></div></div></div></div></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Aug 3, 2019 at 6:24 AM Chen, Shengzhe <<a href="mailto:schen26@albany.edu">schen26@albany.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div style="direction:ltr">
<div style="direction:ltr">Hi Prof. Smith, Fenton and Wang,</div>
<div style="direction:ltr">I am on vacation this week and I’m not familiar with the git fork yet.</div>
<div style="direction:ltr">And yes, all I did was change * to + and the results look pretty good to me.</div>
<div style="direction:ltr">It doesn’t really matter if I am the one to make the modification. It’s all good as long as the codes got fixed. Thank you all for the suggestion and kindness. I will be using the Ecco data and dig further for my research so I would
like to keep in touch. Thank you again for the tutorial materials online which is extremely helpful to me!</div>
<div style="direction:ltr">Best,</div>
<div style="direction:ltr">Shengzhe</div>
<div><br>
</div>
<div class="gmail-m_-4122301050129511779ms-outlook-ios-signature">Get <a href="https://aka.ms/o0ukef" target="_blank">Outlook for iOS</a></div>
</div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_-4122301050129511779divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Timothy Andrew Smith <<a href="mailto:timsmith204@utexas.edu" target="_blank">timsmith204@utexas.edu</a>><br>
<b>Sent:</b> Friday, August 2, 2019 8:12:43 AM<br>
<b>To:</b> Fenty, Ian G (US 329C) <<a href="mailto:ian.fenty@jpl.nasa.gov" target="_blank">ian.fenty@jpl.nasa.gov</a>>; Chen, Shengzhe <<a href="mailto:schen26@albany.edu" target="_blank">schen26@albany.edu</a>><br>
<b>Cc:</b> ECCO support list, wider membership <<a href="mailto:ecco-support@mit.edu" target="_blank">ecco-support@mit.edu</a>>; Wang, Ou (US 329B) <<a href="mailto:ou.wang@jpl.nasa.gov" target="_blank">ou.wang@jpl.nasa.gov</a>><br>
<b>Subject:</b> Re: [EXTERNAL] [ecco-support] Potential errors in ecco-v4-py python package</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div>
<div dir="auto">Hey Shengze,</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">Thank you for the feedback and good catch! This looks like a pretty small (but consequential!) typo on a script that I had added. </div>
<div dir="auto"><br>
</div>
<div>It looks like the fix is as simple as *->+ in those few lines of the functions calc_section_heat_trsp and calc_section_salt_trsp (within calc_section_trsp.py). </div>
<div><br>
</div>
<div>I would be happy to do this, but as Ian said, if you are familiar or comfortable with
<a href="https://help.github.com/en/articles/creating-a-pull-request-from-a-fork" target="_blank">
submitting a pull request</a> from a <a href="https://help.github.com/en/articles/fork-a-repo" target="_blank">
forked</a> version of <a href="https://github.com/ECCO-GROUP/ECCOv4-py" target="_blank">ECCOv4-py</a> with the code changes then this would be ideal because it will attribute the fix to you. If you're unfamiliar and need some pointers, don't hesitate to contact me - I'm happy
to help. Let me know what you want to do here. </div>
<div><br>
</div>
<div>Cheers,</div>
<div>Tim</div>
</div>
<div><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Aug 1, 2019 at 22:02 Fenty, Ian G (US 329C) <<a href="mailto:ian.fenty@jpl.nasa.gov" target="_blank">ian.fenty@jpl.nasa.gov</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div class="gmail-m_-4122301050129511779gmail-m_8787002170727277232m_-6638934832794343253WordSection1">
<p class="MsoNormal">Dear Shengzhe,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thank you for identifying the bug in cal_section_trsp and telling us about it. Would you mind please sending the code with the bug fix to
<a href="mailto:ian.fenty@jpl.nasa.gov" target="_blank">ian.fenty@jpl.nasa.gov</a> and
<a href="mailto:Ou.Wang@jpl.nasa.gov" target="_blank">Ou.Wang@jpl.nasa.gov</a>. One of us will make sure that the code is fixed and that you are given credit!
<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Of course, if you are familiar with github, you can propose the code change yourself. Here is the python package repository:
<a href="https://github.com/ECCO-GROUP/ECCOv4-py" target="_blank">https://github.com/ECCO-GROUP/ECCOv4-py</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">-Ian<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12pt;color:black">From: </span></b><span style="font-size:12pt;color:black"><<a href="mailto:ecco-support-bounces@mit.edu" target="_blank">ecco-support-bounces@mit.edu</a>> on behalf of "Chen, Shengzhe" <<a href="mailto:schen26@albany.edu" target="_blank">schen26@albany.edu</a>><br>
<b>Reply-To: </b>"ECCO support list, wider membership" <<a href="mailto:ecco-support@mit.edu" target="_blank">ecco-support@mit.edu</a>><br>
<b>Date: </b>Tuesday, July 23, 2019 at 5:58 PM<br>
<b>To: </b>"<a href="mailto:ecco-support@mit.edu" target="_blank">ecco-support@mit.edu</a>" <<a href="mailto:ecco-support@mit.edu" target="_blank">ecco-support@mit.edu</a>><br>
<b>Subject: </b>[EXTERNAL] [ecco-support] Potential errors in ecco-v4-py python package<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div id="gmail-m_-4122301050129511779gmail-m_8787002170727277232m_-6638934832794343253divtagdefaultwrapper">
<p><span style="font-size:12pt;color:black">Hi there,<u></u><u></u></span></p>
<p><span style="font-size:12pt;color:black">This is Shengzhe Chen, 3rd-year graduate student from UAlbany. Thanks to Dr. Ian Fenty, I am able to learn from the python packages to process ECCOv4 data. <u></u><u></u></span></p>
<p><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
<p><span style="font-size:12pt;color:black">Recently I was trying to use cal_section_trsp to calculate the salt and heat transport through some straits in the Arctic. I found that the results are very different from the observation data (e.g. mooring data)
in terms of magnitude. The observation data often show heat transport in the magnitude of TW, where the results generated by ECCOv4 show magnitude of hundreds of TW (PW to TW was done). I then went through the cal_section_trsp codes and compare them with gcmfaces
Matlab codes written by Dr. Gael Forget. I found that in heat transport and salt transport part of ECCO-v4-py, a Multiplication sign instead of a plus sign is assigned to combine the advective flux of potential temperature (e.g. </span><span style="font-size:9pt;font-family:Consolas;color:rgb(3,47,98)">ADVx_TH</span><span style="font-size:12pt;color:black">)
and diffusive flux of potential temperature (e.g. </span><span style="font-size:9pt;font-family:Consolas;color:rgb(3,47,98)">DFxE_TH</span><span style="font-size:12pt;color:black">). <u></u><u></u></span></p>
<p><span style="font-size:12pt;color:black">After I changed the sign from multiplication to plus, the results look more similar to observation data.<u></u><u></u></span></p>
<p><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
<p><span style="font-size:12pt;color:black">Thank you again for the great work of Python package which helps me a lot to take advantage of ECCOv4 data.<u></u><u></u></span></p>
<p><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
<p><span style="font-size:12pt;color:black">Best,<u></u><u></u></span></p>
<p><span style="font-size:12pt;color:black">Shengzhe<u></u><u></u></span></p>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote></div>