[Wocky] Flaw in reciprocal buddy-adding

[Greg Hudson]

> Confusing matters, the conditional in step 7 only appears on the
> gaim 1.5 branch, along with a bunch of other work which never seems
> to have made it to the mainline.  So Gaim 2.0 probably doesn't
> manifest this bug, but might manifest other bugs instead.

> I will test some candidate fixes soon, and will also try this
> scenario and some related scenarios in the Gaim 2.0 beta.

As I expected, Gaim 2.0 beta exhibits differently-buggy behavior.
With the older code (which is in the newer release), the reciprocal
buddy add works, but the local buddy list winds up with two entries
for the same buddy, one of which is functional and one of which is
not.  The redundant entry does not exist on the server, so if you quit
and restart Gaim, the redundant entry is cleaned up and you wind up
with just one, functional buddy entry.

I came up with a fix for the Gaim 1.5 behavior which does the right
thing: if you're trying to add a buddy which already exists, tell the
server to add it, but don't redundantly add it to the local buddy
list.  I've checked this into the Gaim repository in
/afs/dev.mit.edu/project/jabber, in anticipation of a local deployment
with some Jabber fixes and GSSAPI support.

There was an old bug entry for the old bug, so I submitted my findings
there.  See:

https://sourceforge.net/tracker/?func=detail&atid=100235&aid=1041829&group_id=235