You know what I hate?

[Dart, Jocelyn]

Looking at other people's code is always a bit of a rollercoaster ride
... it can be soooo depressing...  or show you a really good approach
you've not used before. 

Not a good activity for this time of year. 

Have a happy Christmas everyone!


Regards,
Jocelyn Dart
Senior Consultant
SAP Australia Pty Ltd.
Level 1/168 Walker St.
North Sydney 
NSW, 2060
Australia
T   +61 412 390 267
M   + 61 412 390 267
E   jocelyn.dart at sap.com
http://www.sap.com

The information contained in or attached to this electronic transmission
is confidential and may be legally privileged. It is intended only for
the person or entity to which it is addressed. If you are not the
intended recipient, you are hereby notified that any distribution,
copying, review, retransmission, dissemination or other use of this
electronic transmission or the information contained in it is strictly
prohibited. If you have received this electronic transmission in error,
please immediately contact the sender to arrange for the return of the
original documents. 
Electronic transmission cannot be guaranteed to be secure and
accordingly, the sender does not accept liability for any such data
corruption, interception, unauthorized amendment, viruses, delays or the
consequences thereof.
Any views expressed in this electronic transmission are those of the
individual sender, except where the message states otherwise and the
sender is authorized to state them to be the views of SAP AG or any of
its subsidiaries. SAP AG, its subsidiaries, and their directors,
officers and employees make no representation nor accept any liability
for the accuracy or completeness of the views or information contained
herein. Please be aware that the furnishing of any pricing information/
business proposal herein is indicative only, is subject to change and
shall not be construed as an offer or as constituting a binding
agreement on the part of SAP AG or any of its subsidiaries to enter into
any relationship, unless otherwise expressly stated. 


-----Original Message-----
From: sap-wug-bounces at mit.edu [mailto:sap-wug-bounces at mit.edu] On Behalf
Of Mike Pokraka
Sent: Wednesday, 20 December 2006 10:27 AM
To: SAP Workflow Users' Group
Subject: Re: You know what I hate?

Ah but not when missioning through WF logs and containers when 
troubleshooting some unknown client's botched upgrade. Or reading ABAP 
code that does SWC_GET_PROPERTYs of other objects.

Talking of which: Recently seen at a client - change the SELECT portion 
of a DB attribute's code to alter the header line before assigning it to

OBJECT._BKPF. Why? So they could read a 'virtual attribute' without 
actually creating one - just overwrite a DB attribute they didn't need 
with the calculated value. Now THAT's plain nasty.

Cheers,
Mike


Dart, Jocelyn wrote:
> Surely it's easy to spot anyway... as that was the whole point of the
> white/red colour coding to indicate inheritance vs local methods? 
> 
> 
> Regards,
> Jocelyn Dart
> Senior Consultant
> SAP Australia Pty Ltd.
> Level 1/168 Walker St.
> North Sydney 
> NSW, 2060
> Australia
> T   +61 412 390 267
> M   + 61 412 390 267
> E   jocelyn.dart at sap.com
> http://www.sap.com
> 
> The information contained in or attached to this electronic
transmission
> is confidential and may be legally privileged. It is intended only for
> the person or entity to which it is addressed. If you are not the
> intended recipient, you are hereby notified that any distribution,
> copying, review, retransmission, dissemination or other use of this
> electronic transmission or the information contained in it is strictly
> prohibited. If you have received this electronic transmission in
error,
> please immediately contact the sender to arrange for the return of the
> original documents. 
> Electronic transmission cannot be guaranteed to be secure and
> accordingly, the sender does not accept liability for any such data
> corruption, interception, unauthorized amendment, viruses, delays or
the
> consequences thereof.
> Any views expressed in this electronic transmission are those of the
> individual sender, except where the message states otherwise and the
> sender is authorized to state them to be the views of SAP AG or any of
> its subsidiaries. SAP AG, its subsidiaries, and their directors,
> officers and employees make no representation nor accept any liability
> for the accuracy or completeness of the views or information contained
> herein. Please be aware that the furnishing of any pricing
information/
> business proposal herein is indicative only, is subject to change and
> shall not be construed as an offer or as constituting a binding
> agreement on the part of SAP AG or any of its subsidiaries to enter
into
> any relationship, unless otherwise expressly stated. 
> 
> 
> -----Original Message-----
> From: sap-wug-bounces at mit.edu [mailto:sap-wug-bounces at mit.edu] On
Behalf
> Of Hill, Anna
> Sent: Wednesday, 20 December 2006 5:21 AM
> To: SAP Workflow Users' Group
> Subject: RE: You know what I hate?
> 
> I completely agree with Mike regarding the z prefix for a method -
> there's also the additional benefit of it being very easy to spot as
you
> just have to scroll down to the bottom when entering your method into
a
> task... (pure laziness of course!). 
> 
> Something else I have come across quite a bit is custom tasks and
> workflows being created without a z pre-fix - this I would
*definitely*
> class as very irritating. One could argue that the numbering alone is
> enough to identify the source of the task but when flitting from
project
> to project, often working under short timescales, by far and away the
> easiest way to spot custom objects is with searching with Z* so I
would
> definitely say a Z pre-fix here is a must. 
> 
> 
> 
> -----Original Message-----
> From: sap-wug-bounces at mit.edu [mailto:sap-wug-bounces at mit.edu] On
Behalf
> Of Mike Pokraka
> Sent: Tuesday, December 19, 2006 11:03 AM
> To: SAP Workflow Users' Group
> Subject: Re: You know what I hate?
> 
> Hmmm, I used to agree with you. The SAP help also suggests using
> ordinary
> English words.
> 
> However over the years of bouncing around different customer sites
> (sometimes in rapid succession, sometimes even just for a single day)
I
> appreciated people using prefixes for much the same reasons Paul
> described. Bughunting/understanding foreign workflows is much easier
if
> it's straightforward to spot which attributes are custom. So these
days
> I'm back in the other side and prefix them with a small z. (I find
caps
> more annoying - as in ZAmount).
> 
> What is annoying is people that create subtypes and call them
ZBUS2096.
> Huh? It's a Debit Memo Request. And your subtype should also be called
> the
> same - perhaps with an 'Enhanced' suffix or similar. So I suaually
> create
> subtypes and add a small z before the original object name - as in
> zCustDebitMemoReq.
> 
> Just my 2p.
> Cheers,
> Mike
> 
> 
> On Mon, December 18, 2006 21:59, Alon Raskin wrote:
>> I know that this is mostly an academic argument but I would love to
> hear
>> peoples thoughts on this...
>>
>> You know what I hate? I hate it when I look at a Z Business Object
>> (delegated sub-type) and someone has created a method called zUpdate
> or an
>> attribute called zAmount. Is there really a need for the 'z' in the
> name
>> of the attribute/method? Perhaps there is something I am missing here
> so
>> please feel free to point out the error of my ways.
>>
>> Do people do this because they don't realise that they can redefine
an
> SAP
>> delivered attribute/method? Or are they concerned that SAP will
> deliver an
>> attribute with the exact same name? I assume that the redefined
>> method/attribute would not be effected but perhaps someone has had
> this
>> happen...
>>
>> I understand why people do it with append fields on a table but why
do
>> this for a BOR sub-type?
>>
>> Regards,
>>
>> Alon
>> _______________________________________________
>> SAP-WUG mailing list
>> SAP-WUG at mit.edu
>> http://mailman.mit.edu/mailman/listinfo/sap-wug
>>
> 
> 
> _______________________________________________
> SAP-WUG mailing list
> SAP-WUG at mit.edu
> http://mailman.mit.edu/mailman/listinfo/sap-wug
> 
> _______________________________________________
> SAP-WUG mailing list
> SAP-WUG at mit.edu
> http://mailman.mit.edu/mailman/listinfo/sap-wug
> 
> _______________________________________________
> SAP-WUG mailing list
> SAP-WUG at mit.edu
> http://mailman.mit.edu/mailman/listinfo/sap-wug

_______________________________________________
SAP-WUG mailing list
SAP-WUG at mit.edu
http://mailman.mit.edu/mailman/listinfo/sap-wug