[PageOneX] [dev] collaborators feature ready?

pablo rey pablo at basurama.org
Tue Jun 11 16:48:35 EDT 2013 

IMPORTANT: Also major bug now: not able to draw areas.

User is able to draw the rectangle, but it doesn't transform into the
colored area.

I tested in development: before pulling it worked, after pulling it doesn't
work.


On Tue, Jun 11, 2013 at 4:38 PM, pablo rey <pablo at basurama.org> wrote:

> I don't know if it is related, but the page to see users (only for admin
> users http://pageonex.com/users) crashes now...
>
> This is the log:
>
> Started GET "/users".......
>
> Processing by UsersController#index as HTML
>   Rendered users/index.html.erb within layouts/application (4.1ms)
> Completed 500 Internal Server Error in 13ms
>
> ActionView::Template::Error (can't convert String into Integer):
>     23:   <tbody>
>     24:     <% @users.each do |user| %>
>     25:       <tr>
>     26:         <td><%= link_to user.id, user_path(user) %></td>
>     27:         <td><%= user.username %></td>
>     28:         <td><%= user.email %></td>
>     29:         <td><%= user.reset_password_token %></td>
>   app/views/users/index.html.erb:26:in `block in
> _app_views_users_index_html_erb__1929642315542844102_32296160'
>   app/views/users/index.html.erb:24:in `each'
>   app/views/users/index.html.erb:24:in
> `_app_views_users_index_html_erb__1929642315542844102_32296160'
>   app/controllers/users_controller.rb:10:in `index'
>
>
>
> On Tue, Jun 11, 2013 at 4:34 PM, pablo rey <pablo at basurama.org> wrote:
>
>> Now I don't see the emails anymore :)
>> And it auto-fills with users name :)
>> but the user doesn't get stored once I save.
>>
>>
>> On Tue, Jun 11, 2013 at 4:29 PM, Edward Platt <elplatt at media.mit.edu>wrote:
>>
>>> Just pulled a fix down to production, can you verify that it's working?
>>>
>>> -Ed
>>>
>>>
>>> On Tue, Jun 11, 2013 at 4:22 PM, pablo rey <pablo at basurama.org> wrote:
>>>
>>>> Hi Ed,
>>>> Would you have time to fix this today? Thanks!
>>>> p
>>>>
>>>>
>>>> On Mon, Jun 10, 2013 at 2:26 PM, Edward Platt <elplatt at media.mit.edu>wrote:
>>>>
>>>>> I'll switch from email to username asap!
>>>>>
>>>>> -Ed
>>>>>
>>>>>
>>>>> On Mon, Jun 10, 2013 at 2:24 PM, pablo rey <pablo at basurama.org> wrote:
>>>>>
>>>>>> My answers bellow.
>>>>>>
>>>>>> *One important security thing*: we should not let the auto-complete,
>>>>>> when adding collaborators, find the user's email. I already pulled in
>>>>>> production, and having all those emails available is not a good thing.
>>>>>>
>>>>>> On Mon, Jun 10, 2013 at 12:42 PM, Edward Platt <elplatt at media.mit.edu
>>>>>> > wrote:
>>>>>>
>>>>>>> Ah, I'll look into the add button.
>>>>>>>
>>>>>>> Thoughts on making the icons more recognizable:
>>>>>>> * We can switch to an identicon (unique geometric shape) for users
>>>>>>> who don't have gravatars.
>>>>>>>
>>>>>> I'll make one.
>>>>>>
>>>>>>  * The icons are currently semi-transparent, should we make them
>>>>>>> fully opaque?
>>>>>>>
>>>>>> To keep the page visualization clean we should display the icons only
>>>>>> when you hover the area. The important thing is still the area, not the
>>>>>> creator.
>>>>>> So make them opaque if we make it only appear when hovering.
>>>>>> You can preview it in this thread
>>>>>> http://pageonex.com/matrushka/gezi-parki-protests-in-turkish-newspapers/coding/?i=haberturk-2013-06-09 with
>>>>>> 2 users.
>>>>>>
>>>>>>
>>>>>>> * We can add the username, but I worry it might start to look
>>>>>>> cluttered.
>>>>>>>
>>>>>> The same here, only when you hover over the icon, you can read the
>>>>>> user's name.
>>>>>>
>>>>>>
>>>>>>>  * Also, should collaborators be identified by email or username?
>>>>>>>  I went with email, just to get the functionality out, but we could switch
>>>>>>> to username.
>>>>>>>
>>>>>> I like the idea of being able to use both username and email. If
>>>>>> that's not possible, better username, so you don't have to ask users for
>>>>>> their emails.
>>>>>>
>>>>>>
>>>>>>> -Ed
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Jun 10, 2013 at 12:33 PM, pablo rey <pablo at basurama.org>wrote:
>>>>>>>
>>>>>>>> Typing in works. The add button seem useless.
>>>>>>>>
>>>>>>>> It looks great Ed! Great improvement.
>>>>>>>>
>>>>>>>> Thinking on adding a tittle tag to the open id image on the area to
>>>>>>>> know who is the coder, some people don't sue open id, or their icon is not
>>>>>>>> recognizable.
>>>>>>>>
>>>>>>>> Also it might be good to list the collaborators in the display
>>>>>>>> view. thoughts?
>>>>>>>>
>>>>>>>> Collaborating is what I've been doing in the Turkish thread using
>>>>>>>> my admin superpowers :)
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Jun 10, 2013 at 11:28 AM, Edward Platt <
>>>>>>>> elplatt at media.mit.edu> wrote:
>>>>>>>>
>>>>>>>>> Try typing it in, does it show up in the autocomplete list?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mon, Jun 10, 2013 at 11:26 AM, pablo rey <pablo at basurama.org>wrote:
>>>>>>>>>
>>>>>>>>>> I copy pasted one of the users emails, but I didn't check if it
>>>>>>>>>> was already a collaborator. I don't think so, I just had enabled the
>>>>>>>>>> feature, just had pulled to dev.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Monday, June 10, 2013, Edward Platt <elplatt at media.mit.edu>
>>>>>>>>>> wrote:
>>>>>>>>>> > Can you verify that the email actually exists?  It only allows
>>>>>>>>>> you to add existing users who aren't already collaborators.  I should add
>>>>>>>>>> error messages for when the entered user isn't valid.
>>>>>>>>>> > -Ed
>>>>>>>>>> >
>>>>>>>>>> > On Mon, Jun 10, 2013 at 1:01 AM, pablo rey <pablo at basurama.org>
>>>>>>>>>> wrote:
>>>>>>>>>> >>
>>>>>>>>>> >> hi Ed,
>>>>>>>>>> >>
>>>>>>>>>> >> I saw you commits about adding collaborators to a thread, and
>>>>>>>>>> I pulled it to dev, but ir is not working. I put one of the user emails,
>>>>>>>>>> clicked "add" but nothing happens. Is this feture ready? I might be doing
>>>>>>>>>> somethin wrong.
>>>>>>>>>> >> p
>>>>>>>>>> >>
>>>>>>>>>> >> ps. the thread on Turkish protests on Turkish newspapers
>>>>>>>>>> http://pageonex.com/matrushka/gezi-parki-protests-in-turkish-newspapers/got 1000+ visits, specially from Turkey (and from facebook).
>>>>>>>>>> >> _______________________________________________
>>>>>>>>>> >> Pageonexdev mailing list
>>>>>>>>>> >> Pageonexdev at mit.edu
>>>>>>>>>> >> http://mailman.mit.edu/mailman/listinfo/pageonexdev
>>>>>>>>>> >>
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> > --
>>>>>>>>>> > Edward L. Platt
>>>>>>>>>> > Civic Technology Programmer
>>>>>>>>>> > MIT Center for Civic Media
>>>>>>>>>> > E15-348
>>>>>>>>>> > http://civic.mit.edu
>>>>>>>>>> > http://elplatt.com
>>>>>>>>>> > @EdwardLPlatt
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Edward L. Platt
>>>>>>>>> Civic Technology Programmer
>>>>>>>>> MIT Center for Civic Media
>>>>>>>>> E15-348
>>>>>>>>> http://civic.mit.edu
>>>>>>>>> http://elplatt.com
>>>>>>>>> @EdwardLPlatt <http://twitter.com/edwardlplatt>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Pageonexdev mailing list
>>>>>>>>> Pageonexdev at mit.edu
>>>>>>>>> http://mailman.mit.edu/mailman/listinfo/pageonexdev
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Edward L. Platt
>>>>>>> Civic Technology Programmer
>>>>>>> MIT Center for Civic Media
>>>>>>> E15-348
>>>>>>> http://civic.mit.edu
>>>>>>> http://elplatt.com
>>>>>>> @EdwardLPlatt <http://twitter.com/edwardlplatt>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Pageonexdev mailing list
>>>>>>> Pageonexdev at mit.edu
>>>>>>> http://mailman.mit.edu/mailman/listinfo/pageonexdev
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Edward L. Platt
>>>>> Civic Technology Programmer
>>>>> MIT Center for Civic Media
>>>>> E15-348
>>>>> http://civic.mit.edu
>>>>> http://elplatt.com
>>>>> @EdwardLPlatt <http://twitter.com/edwardlplatt>
>>>>>
>>>>> _______________________________________________
>>>>> Pageonexdev mailing list
>>>>> Pageonexdev at mit.edu
>>>>> http://mailman.mit.edu/mailman/listinfo/pageonexdev
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Edward L. Platt
>>> Civic Technology Programmer
>>> MIT Center for Civic Media
>>> E15-348
>>> http://civic.mit.edu
>>> http://elplatt.com
>>> @EdwardLPlatt <http://twitter.com/edwardlplatt>
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.mit.edu/pipermail/pageonexdev/attachments/20130611/22b59a77/attachment.htm

More information about the Pageonexdev mailing list