[mosh-devel] Mosh 1.2.5 release candidate 2 available for testing

[Jérémie Courrèges-Anglas]

john hood <cgull at glup.org> writes:

> On 7/2/15 8:43 PM, Jérémie Courrèges-Anglas wrote:
>> 
>> FWIW, mosh-1.2.4.95rc2 builds and works fine on OpenBSD-current, amd64
>> and sparc64 architectures.  This update[1] means that most tweaks and
>> patches are now unneeded in the OpenBSD ports framework.
>
> Thanks for the report!  The port looks pretty good to me.  The one thing
> that I notice is that Mosh needs Perl libraries for IPv6.  It would
> prefer to use IO::Socket::IP for IPv6, if available, or it can fall back
> to IO::Socket::INET6.  So your port should depend on one of these.

We have perl 5.20 (with IO::Socket::IP included) in the base system.

>> There is one remaining patch, related to ARM assembly support.  Since
>> gas on OpenBSD/arm has recently gained support for more opcodes, this
>> patch[2] may now be unneeded.  No idea yet.
>
> Given that mosh compiles and runs on my Raspberry Pi with
> FreeBSD-CURRENT on an RPi, which has an ARMv6 CPU, I would guess it is a
> gas issue.

Well, between 1.2.4 and 1.2.4.95rc2 the affected code was modified:

@@ -298,7 +298,7 @@
         return swap_if_le(rval);
 	}
 
-	#if __GNUC__ && __arm__
+	#if __GNUC__ && !__clang__ && __arm__
 	static inline block double_block(block b) {
 		__asm__ ("adds %1,%1,%1\n\t"
 				 "adcs %H1,%H1,%H1\n\t"


We build mosh using gcc-4.2.1 (base system) on all platforms, I guess
clang is used on FreeBSD / armv6.

The ancient toolchain and the fact that OpenBSD/arm* still use APCS
means that support for ARM assembly in our ports tree is close to
nonexistent.  So this kind of edge case is not something the mosh
project should care about. :)

>> PS: will we have to regen autoconf/make files for 1.2.5-release?
>
> Since you're fetching the distribution tarball, you don't have to.

ACK.

> regards,
>
>   --jh

Cheers,
-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE