kdc 1.10 cleanup patches?

[Chris Hecker]

> If you port it to the current trunk I'll take it.

Cool, I'll do that.

> The adm.h cleanup patch you suggested struck me as a half-measure

Maybe, but a trivial half-measure is better than a duplicate structure
living in there for even more time, no?  I mean, it's been years, and
this fix is really tiny and I've tested it, and it would help clean
things up now.  As a new person spelunking into the kerberos code, it
was kind of shocking to see, and this would help with that, even if it's
not the full "correct answer".

Thanks,
Chris


On 2012/02/15 22:49, Greg Hudson wrote:
> On 02/16/2012 01:03 AM, Chris Hecker wrote:
>> I know my "banning" fix needs more consideration, but if I port these
>> two cleanup patches up to 1.10, is there any chance to get them
>> integrated?
> 
> The DB entry one is simple enough; I just didn't get around to looking
> at it.  If you port it to the current trunk I'll take it.
> 
> The adm.h cleanup patch you suggested struck me as a half-measure, and I
> deferred it because I was afraid of stirring the pot without really
> cleaning up the mess.  The correct answer is to make the KDC use the
> same interfaces as the kadmin programs do, which requires care to avoid
> accidental behavior changes.
>