[RFC][PATCH] krb5 => libverto main loop

Nathaniel McCallum nmccallu at redhat.com
Tue Sep 13 10:12:43 EDT 2011

Attached patches address these issues.

----- Original Message -----
From: "Greg Hudson" <ghudson at MIT.EDU>
To: "Nathaniel McCallum" <nmccallu at redhat.com>
Cc: "krbdev at mit.edu" <krbdev at MIT.EDU>
Sent: Monday, September 12, 2011 12:35:24 PM
Subject: Re: [RFC][PATCH] krb5 => libverto main loop

On Fri, 2011-09-09 at 16:57 -0400, Nathaniel McCallum wrote:
> Attached is a series of patches to deal with these issues.

In patch 2, loop_setup_signals() doesn't have correct error handling (it
deletes ctx, which is now an input parameter), and also has wonky
indentation for the goto label and following code.

Also, there is still a race where the master KDC receives a termination
signal just after forking the worker children and kills off the child
processes during the window where some or all of them are still trapping
signals in on_monitor_* (which causes them to be effectively ignored).
This race is unlikely to affect anyone (even the test suite), but we can
handle it in create_workers() by adding an "if (signal_received)
exit(0);" after calling loop_setup_signals().

krbdev mailing list             krbdev at mit.edu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-reinitialize-verto-after-the-fork-make-the-proper-so.patch
Type: text/x-patch
Size: 2265 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/krbdev/attachments/20110913/fc2f88a3/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-split-out-signal-event-setup-from-loop_init-into-loo.patch
Type: text/x-patch
Size: 6556 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/krbdev/attachments/20110913/fc2f88a3/attachment-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-move-the-child-signal-handlers-to-before-the-fork-to.patch
Type: text/x-patch
Size: 2631 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/krbdev/attachments/20110913/fc2f88a3/attachment-0002.bin

More information about the krbdev mailing list