[RFC][PATCH] krb5 => libverto main loop

Greg Hudson ghudson at MIT.EDU
Mon Sep 12 12:35:24 EDT 2011

On Fri, 2011-09-09 at 16:57 -0400, Nathaniel McCallum wrote:
> Attached is a series of patches to deal with these issues.

In patch 2, loop_setup_signals() doesn't have correct error handling (it
deletes ctx, which is now an input parameter), and also has wonky
indentation for the goto label and following code.

Also, there is still a race where the master KDC receives a termination
signal just after forking the worker children and kills off the child
processes during the window where some or all of them are still trapping
signals in on_monitor_* (which causes them to be effectively ignored).
This race is unlikely to affect anyone (even the test suite), but we can
handle it in create_workers() by adding an "if (signal_received)
exit(0);" after calling loop_setup_signals().

More information about the krbdev mailing list