Review ofhttp://k5wiki.kerberos.org/wiki/Projects/PAC_and_principal_APIs ending January 10

[Love Hörnquist Åstrand]

23 dec 2008 kl. 23:56 skrev Luke Howard:

>>>> #define KRB5_PRINCIPAL_UNPARSE_SHORT 1 #define
>>>> KRB5_PRINCIPAL_UNPARSE_NO_REALM 2 #define
>>>> KRB5_PRINCIPAL_UNPARSE_DISPLAY 4
>>
>>   Ken> ... which mean what precisely?
>> Luke?
>
> Again, these are from Heimdal.
>
> KRB5_PRINCIPAL_UNPARSE_SHORT -- omit the realm if it is the local  
> realm.
> KRB5_PRINCIPAL_UNPARSE_NO_REALM -- omit the realm always.
> KRB5_PRINCIPAL_UNPARSE_DISPLAY -- don't escape.
>
>>
>>>> #define KRB5_PRINCIPAL_PARSE_NO_REALM 1
>>
>>   Ken> Absence of realm is okay?  Discard the supplied realm?
>> Luke?
>
> KRB5_PRINCIPAL_PARSE_NO_REALM omits the realm in the parsed principal.
>
>>>> #define KRB5_PRINCIPAL_PARSE_MUST_REALM 2
>>
>>   Ken> "Realm" not verb.  Better name?  "Require"?
>>
>> If this is shipping in Heimdal, I think we should keep it.
>> Otherwise I'm happy to change.
>
> I believe it is shipping in Heimdal. KRB5_PRINCIPAL_PARSE_MUST_REALM
> requires that the to-be-parsed name has a realm component.

Yes, KRB5_PRINCIPAL_PARSE_NO_REALM and KRB5_PRINCIPAL_PARSE_MUST_REALM  
are each other opposite.

I like the suggestion to rename KRB5_PRINCIPAL_PARSE_MUST_REALM to  
KRB5_PRINCIPAL_PARSE_REQUIRE_REALM, lets do that.

Love