The Removal of Colors (ticket 5607)

[Kevin Koch]

You are right that the bg_hdr_def isn't the same as bg_hdr.

Isn't the right behavior to honor the windows color settings and set bg_hdr
to GetSysColor(ColorWindow)?

Just curious, why is this is krbdev instead of kfwdev?

Kevin 

-----Original Message-----
From: krbdev-bounces at MIT.EDU [mailto:krbdev-bounces at MIT.EDU] On Behalf Of
Jeffrey Altman
Sent: Wednesday, August 15, 2007 8:42 AM
To: 'krbdev at mit.edu'
Subject: The Removal of Colors (ticket 5607)

This patch from ticket 5607 which was applied to the trunk and pulled up
to 1-6 is wrong.

Index: credwnd.c
===================================================================
--- credwnd.c   (revision 19739)
+++ credwnd.c   (working copy)
@@ -685,7 +689,7 @@
         COLORREF bg_hdr_warn = RGB(235,235,134);
         COLORREF bg_hdr_crit = RGB(235,184,134);
         COLORREF bg_hdr_exp = RGB(235,134,134);
-        COLORREF bg_hdr_def = RGB(184,235,134);
+        COLORREF bg_hdr_def = GetSysColor(COLOR_WINDOW);

         tbl->cr_normal =       GetSysColor(COLOR_WINDOWTEXT);
         tbl->cr_s =            GetSysColor(COLOR_WINDOWTEXT);

If you want the default background header color, bg_hdr_def, to be the
same as the rest of the header colors, then you must set it to the same
value as the other header background colors, bg_hdr.

        COLORREF bg_s = GetSysColor(COLOR_HIGHLIGHT);
        COLORREF bg_normal = GetSysColor(COLOR_WINDOW);
        COLORREF bg_gray = RGB(240,240,240);
        COLORREF bg_hdr = RGB(240,240,240);
        COLORREF bg_hdr_warn = RGB(235,235,134);
        COLORREF bg_hdr_crit = RGB(235,184,134);
        COLORREF bg_hdr_exp = RGB(235,134,134);
        COLORREF bg_hdr_def = GetSysColor(COLOR_WINDOW);

RGB(240,240,240) != GetSysColor(ColorWindow)

Jeffrey Altman