krb5_get_server_rcache double free

[Shawn M. Emery]

Rainer Weikusat wrote:
> The krb5_rc_close routine should free rcache, according to the
> documentation for this and I of course checked that it does free
> rcache. The claim that
>
> 	When krb5_rc_recover_or_initialize() returns failure, rcache
> 	now leaks.
>
> is therefore wrong and the only real effect of this chain of
> conversation is restoring the never called free at the end of the
> get_server_rcache routine. 
>
> <URL:http://krbdev.mit.edu/rt/Ticket/Display.html?id=3962>
>
> Publishing factually incorrect statements about other people on the
> WWW is not so nice.
>   

Argh, I apologize Rainer, as I was not trying to personally target you.  
The current solution does work, but as you mentioned the rcache check is 
an extra step that I didn't account for when I fixed this in our release 
back in February.

Sincerely,

Shawn.
--