[krbdev.mit.edu #7815] AutoReply: Text relocations in iaesx86.s

[Tom Yu via RT]

"nalin at redhat.com via RT" <rt-comment at krbdev.mit.edu> writes:

>> I'm pretty sure those added directives are redundant if we're leaving
>> shuffle_mask in .data rather than moving it to .rodata.
>
> Yes, of course you're right, they are.  Either we move shuffle_mask to
> .rodata, or this hunk is redundant.  I have a mild preference for using
> .rodata, as you suggested earlier.

I have a preference for leaving it in .data for now, for minimizing
the change and to match iaesx64.s.  We can make a cleanup pass later
that moves stuff to .rodata and gets rid of some dead code and data.
I think shuffle_mask is the only data label actually used in that
file.

Proposed commit in the aesni-reloc branch on my GitHub fork:
https://github.com/tlyu/krb5/commit/3847aa109e8ff3f2781d53315f81e8d29ee35892