[krbdev.mit.edu #7815] AutoReply: Text relocations in iaesx86.s

[nalin@redhat.com via RT]

On Fri, Jan 10, 2014 at 02:38:47PM -0500, Tom Yu via RT wrote:
> "nalin at redhat.com via RT" <rt-comment at krbdev.mit.edu> writes:
> 
> > --- krb5-1.12/src/lib/crypto/builtin/aes/iaesx86.s
> > +++ krb5-1.12/src/lib/crypto/builtin/aes/iaesx86.s
> > @@ -224,6 +224,8 @@
> >  DD 07060504h
> >  DD 0B0A0908h
> >  
> > +section .data
> > +align 16
> >  byte_swap_16:
> >  DDQ 0x000102030405060708090A0B0C0D0E0F
> 
> I'm pretty sure those added directives are redundant if we're leaving
> shuffle_mask in .data rather than moving it to .rodata.

Yes, of course you're right, they are.  Either we move shuffle_mask to
.rodata, or this hunk is redundant.  I have a mild preference for using
.rodata, as you suggested earlier.