why are there two krb5_realm_params, in adm.h and admin.h?

[Chris Hecker]

It looks like adm.h is only included in three files in the kdc right now 
(do_as_req.c, kdc_util.c, and main.c), and the krb5_realm_params from 
adm.h is actualy only used in main.c.  Is there any problem with just 
removing the dupe struct from adm.h, an then including kadm5/admin.h in 
kdc/main.c to get the struct declaration?

As my set of changes grows, making Greg more and more uncomfortable...

:)

Chris


On 2011/07/26 15:03, Greg Hudson wrote:
> On Tue, 2011-07-26 at 17:38 -0400, Chris Hecker wrote:
>> If I want to add a bool flag to the realms section of kdc.conf, it seems
>> like it should go in krb5_realm_params, but which struct should I
>> modify?  Both?  How does this even compile?  Are they just not ever both
>> included in the same file?  Is one exported to plugins or something and
>> has to stay stable?
>
> This is an old mess which just hasn't been cleaned up.  adm.h is used in
> the KDC code; kadm5/admin.h is used everywhere else.  adm.h isn't
> installed and has no external stability guarantees, and would probably
> be the one to go away in a more perfect tree.  kadm5/admin.h is
> installed but has explicitly weak stability guarantees.
>
> At the moment you'll need to make changes to both structures.
>
>
>