[ecco-support] [EXTERNAL] Potential errors in ecco-v4-py python package

[Fenty, Ian G (US 329C)]

Dear Shengzhe,

Thank you for identifying the bug in cal_section_trsp and telling us about it.  Would you mind please sending the code with the bug fix to ian.fenty at jpl.nasa.gov<mailto:ian.fenty at jpl.nasa.gov> and Ou.Wang at jpl.nasa.gov<mailto:Ou.Wang at jpl.nasa.gov>.  One of us will make sure that the code is fixed and that you are given credit!

Of course, if you are familiar with github, you can propose the code change yourself.  Here is the python package repository:  https://github.com/ECCO-GROUP/ECCOv4-py

-Ian


From: <ecco-support-bounces at mit.edu> on behalf of "Chen, Shengzhe" <schen26 at albany.edu>
Reply-To: "ECCO support list, wider membership" <ecco-support at mit.edu>
Date: Tuesday, July 23, 2019 at 5:58 PM
To: "ecco-support at mit.edu" <ecco-support at mit.edu>
Subject: [EXTERNAL] [ecco-support] Potential errors in ecco-v4-py python package


Hi there,

This is Shengzhe Chen, 3rd-year graduate student from UAlbany. Thanks to Dr. Ian Fenty, I am able to learn from the python packages to process ECCOv4 data.



Recently I was trying to use cal_section_trsp to calculate the salt and heat transport through some straits in the Arctic. I found that the results are very different from the observation data (e.g. mooring data) in terms of magnitude. The observation data often show heat transport in the magnitude of TW, where the results generated by ECCOv4 show magnitude of hundreds of TW (PW to TW was done). I then went through the cal_section_trsp codes and compare them with gcmfaces Matlab codes written by Dr. Gael Forget. I found that in heat transport and salt transport part of ECCO-v4-py, a Multiplication sign instead of a plus sign is assigned to combine the advective flux of potential temperature (e.g. ADVx_TH) and diffusive flux of potential temperature (e.g. DFxE_TH).

After I changed the sign from multiplication to plus, the results look more similar to observation data.



Thank you again for the great work of Python package which helps me a lot to take advantage of ECCOv4 data.



Best,

Shengzhe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.mit.edu/pipermail/ecco-support/attachments/20190801/d4448d42/attachment.html