svn rev #21782: trunk/src/ kdc/ lib/kadm5/srv/ lib/kdb/ lib/krb5/os/ plugins/preauth/pkinit/

[ghudson@MIT.EDU]

http://src.mit.edu/fisheye/changelog/krb5/?cs=21782
Commit By: ghudson
Log Message:
Add some output parameter initializations n order to eliminate some
spurious Coverity defects.  (Far from a comprehensive pass.)



Changed Files:
U   trunk/src/kdc/network.c
U   trunk/src/lib/kadm5/srv/svr_iters.c
U   trunk/src/lib/kdb/kdb5.c
U   trunk/src/lib/krb5/os/read_msg.c
U   trunk/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
Modified: trunk/src/kdc/network.c
===================================================================
--- trunk/src/kdc/network.c	2009-01-23 05:02:07 UTC (rev 21781)
+++ trunk/src/kdc/network.c	2009-01-23 06:51:03 UTC (rev 21782)
@@ -1163,6 +1163,7 @@
     krb5_error_code retval;
     krb5_data *scratch;
 
+    *out = NULL;
     memset(&errpkt, 0, sizeof(errpkt));
 
     retval = krb5_us_timeofday(kdc_context, &errpkt.stime, &errpkt.susec);

Modified: trunk/src/lib/kadm5/srv/svr_iters.c
===================================================================
--- trunk/src/lib/kadm5/srv/svr_iters.c	2009-01-23 05:02:07 UTC (rev 21781)
+++ trunk/src/lib/kadm5/srv/svr_iters.c	2009-01-23 06:51:03 UTC (rev 21782)
@@ -192,7 +192,8 @@
      char *regexp;
      int i, ret;
      kadm5_server_handle_t handle = server_handle;
-     
+
+     *princs = NULL;
      *count = 0;
      if (exp == NULL)
 	  exp = "*";

Modified: trunk/src/lib/kdb/kdb5.c
===================================================================
--- trunk/src/lib/kdb/kdb5.c	2009-01-23 05:02:07 UTC (rev 21781)
+++ trunk/src/lib/kdb/kdb5.c	2009-01-23 06:51:03 UTC (rev 21782)
@@ -1861,6 +1861,9 @@
     krb5_tl_data tl_data;
     krb5_error_code code;
 
+    *mod_princ = NULL;
+    *mod_time = 0;
+
     tl_data.tl_data_type = KRB5_TL_MOD_PRINC;
 
     if ((code = krb5_dbe_lookup_tl_data(context, entry, &tl_data)))

Modified: trunk/src/lib/krb5/os/read_msg.c
===================================================================
--- trunk/src/lib/krb5/os/read_msg.c	2009-01-23 05:02:07 UTC (rev 21781)
+++ trunk/src/lib/krb5/os/read_msg.c	2009-01-23 06:51:03 UTC (rev 21782)
@@ -37,7 +37,10 @@
 	int		len2, ilen;
 	char		*buf = NULL;
 	int		fd = *( (int *) fdp);
-	
+
+	inbuf->data = NULL;
+	inbuf->length = 0;
+
 	if ((len2 = krb5_net_read(context, fd, (char *)&len, 4)) != 4)
 		return((len2 < 0) ? errno : ECONNABORTED);
 	len = ntohl(len);

Modified: trunk/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
===================================================================
--- trunk/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c	2009-01-23 05:02:07 UTC (rev 21781)
+++ trunk/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c	2009-01-23 06:51:03 UTC (rev 21782)
@@ -2259,6 +2259,9 @@
     unsigned char *p = NULL;
     ASN1_INTEGER *pub_key = NULL;
 
+    *dh_pubkey = *server_key = NULL;
+    *dh_pubkey_len = *server_key_len = 0;
+
     /* get client's received DH parameters that we saved in server_check_dh */
     dh = cryptoctx->dh;