svn rev #21781: trunk/src/lib/krb5/rcache/

[ghudson@MIT.EDU]

http://src.mit.edu/fisheye/changelog/krb5/?cs=21781
Commit By: ghudson
Log Message:
Per coding standards, don't declare variables in inner scopes in new
rcache code except when it really makes sense (option processing for
t_replay).



Changed Files:
U   trunk/src/lib/krb5/rcache/rc_dfl.c
U   trunk/src/lib/krb5/rcache/t_replay.c
Modified: trunk/src/lib/krb5/rcache/rc_dfl.c
===================================================================
--- trunk/src/lib/krb5/rcache/rc_dfl.c	2009-01-23 00:46:46 UTC (rev 21780)
+++ trunk/src/lib/krb5/rcache/rc_dfl.c	2009-01-23 05:02:07 UTC (rev 21781)
@@ -658,8 +658,8 @@
     size_t clientlen, serverlen;
     unsigned int len;
     krb5_error_code ret;
-    struct k5buf buf;
-    char *ptr;
+    struct k5buf buf, extbuf;
+    char *ptr, *extstr;
 
     clientlen = strlen(rep->client);
     serverlen = strlen(rep->server);
@@ -670,8 +670,6 @@
          * in regular format (without the message hash) for the
          * benefit of old implementations.
          */
-        struct k5buf extbuf;
-        char *extstr;
 
         /* Format the extension value so we know its length. */
         krb5int_buf_init_dynamic(&extbuf);

Modified: trunk/src/lib/krb5/rcache/t_replay.c
===================================================================
--- trunk/src/lib/krb5/rcache/t_replay.c	2009-01-23 00:46:46 UTC (rev 21780)
+++ trunk/src/lib/krb5/rcache/t_replay.c	2009-01-23 05:02:07 UTC (rev 21781)
@@ -68,6 +68,9 @@
     FILE *fp;
     krb5_deltat lifespan;
     krb5_int16 vno;
+    char *str;
+    krb5_int32 usec;
+    krb5_timestamp timestamp;
 
     fp = fopen(filename, "r");
     if (!fp) {
@@ -80,10 +83,6 @@
         return;
     printf("Lifespan: %ld\n", (long) lifespan);
     while (1) {
-        char *str;
-        krb5_int32 usec;
-        krb5_timestamp timestamp;
-
         printf("---\n");
 
         if (!(str = read_counted_string(fp)))
@@ -114,6 +113,7 @@
     krb5_error_code retval = 0;
     char *hash = NULL;
     krb5_donot_replay rep;
+    krb5_data d;
 
     if (now_timestamp > 0)
         krb5_set_debugging_time(ctx, now_timestamp, now_usec);
@@ -122,8 +122,6 @@
     if ((retval = krb5_rc_recover_or_initialize(ctx, rc, ctx->clockskew)))
         goto cleanup;
     if (msg) {
-        krb5_data d;
-
         d.data = msg;
         d.length = strlen(msg);
         if ((retval = krb5_rc_hash_message(ctx, &d, &hash)))