[panda-users] syscalls2 and reserved words

[Brendan Dolan-Gavitt]

I'm not sure why "data" is in there, but "cpu" is there because it's
the name of the CPUState argument passed to every syscall callback. I
agree that the best way to find out is probably to remove it from the
restricted words and see what breaks :)

-Brendan

On Mon, Oct 14, 2019 at 8:42 AM Leek, Timothy - 0559 - MITLL
<tleek at ll.mit.edu> wrote:
>
> Hi Laura.  A great idea and thank you!  I had a hand in writing the original version of said script but can’t recall why those tokens were included as reserved.  However, according to git-blame there isn’t much left of Achille’s ship.  One option would be to remove those words from the script and run it and see what happens?  My guess is that they “handled” some annoying failure.
>
> Sent from my iPad
>
> On Oct 14, 2019, at 7:17 AM, Mann, Laura L [US] (MS) <laura.mann at ngc.com> wrote:
>
> We’re looking at updating the syscalls2 plugin to work with 64-bit linux.  There’s a list of “reserved” words in the syscall_parser.py file that is used to determine what system call argument names need to be renamed.  I understand why “new” and “int” are in the list – they are C/C++ reserved words.  But why are “cpu” and “data” in the list?  Under what definition of “reserved” words do they fall?
>
> There are some new system call argument names in the 64-bit system calls, and I want to ensure any which are “reserved” (under whatever definition is being used) are so indicated.
>
>
>
> Thanks,
>
> Laura L. Mann
>
>
>
> _______________________________________________
> panda-users mailing list
> panda-users at mit.edu
> http://mailman.mit.edu/mailman/listinfo/panda-users
> _______________________________________________
> panda-users mailing list
> panda-users at mit.edu
> http://mailman.mit.edu/mailman/listinfo/panda-users