[PageOneX] [dev] Problems with PageOneX house cleaning and upgrading to bootstrap 3.3.7

[pablo rey]

Good point: carousel it is now included by default in bootstrap
http://getbootstrap.com/javascript/#carousel
So there shouldn't be a problem. I haven't seen big differences in the
documentation:

   - version 2.3.2 http://getbootstrap.com/2.3.2/javascript.html#carousel
   - version 3.3.7 http://getbootstrap.com/javascript/#carousel

I've removed the outdated version of bootstrap-carousel.js, so I am using
the carousel that is inside the boostrap.js file.

The problems persist:

   - It is not possible to draw areas on the front pages. If you try, the
   vertical scroll bar of the browser freezes. When clicking "save and
   display" it throws this error:

   ActiveRecord::RecordNotFound in
   CodingController#process_highlighted_areas
   Couldn't find Code with id=

   app/controllers/coding_controller.rb:35:in `block in
process_highlighted_areas'
   app/controllers/coding_controller.rb:29:in `each'
   app/controllers/coding_controller.rb:29:in `process_highlighted_areas'

   - The carousel of images initiates itself and it is not possible to stop
   it.
   - The count of images coded while coding also doesn't work.

And some more:

   - See image attached): in the carousel there is always one image of the
   same front page (The Seatle times) below the image that I want to code.
   - Drawing areas and saving them works for the first font page, but only
   if there is one topic (category) defined in the thread. For the next front
   pages it is not possible to draw new areas.

There must be something in with the new bootstrap that is interfering with
how things work.

Ideas where to look at?




On Fri, Oct 21, 2016 at 8:47 PM, Rahul B <rahulb at media.mit.edu> wrote:

> You should see if they have a new version, for comparability with
> bootstrap 3.
>
> Rahul
> On Fri, Oct 21, 2016 at 9:04 AM pablo rey <pablo at basurama.org> wrote:
>
>> Nope, I haven't touched the bootstrap-carousel.js file.
>>
>> On Fri, Oct 21, 2016 at 2:59 PM, Rahul B <rahulb at media.mit.edu> wrote:
>>
>> Congrats on the paper!
>>
>> First question - Did you update the carousel library as well?
>>
>> Rahul
>> On Thu, Oct 20, 2016 at 5:41 AM pablo rey <pablo at basurama.org> wrote:
>>
>> Hi everyone,
>> It's been a while ;)
>>
>> I was doing a bit of house cleaning to http://PageOneX.com and planning
>> to add some new features to the tool.
>>
>> I started with an upgrade to the Twitter Bootstrap
>> <http://getbootstrap.com/> (a HTML, CSS, and JS framework). It was at
>> version 2.3.1 and we are upgrading to 3.3.7.
>>
>> Everything went well except the Coding (example of coding in production
>> server
>> <http://pageonex.com/numeroteca/corrupcion-espana-octubre-2016/coding/?i=724066>)
>> part, the section where you the user is able to draw the areas on top of
>> the front pages:
>> + After the changes, it is not possible to draw areas on the front pages
>> and the carousel of images initiates itself and it is not possible to stop
>> it.
>> + The count of images coded while coding also doesn't work
>>
>> Issue open: https://github.com/numeroteca/pageonex/issues/202
>>
>> Ideas about how to fix this?
>> How is the new bootstrap interfering with /app/assets/javascripts/
>> bootstrap-carousel.js
>> <https://github.com/numeroteca/pageonex/blob/master/app/assets/javascripts/bootstrap-carousel.js>
>> that makes the carousel work?
>>
>> I've opened a new branch
>> <https://github.com/numeroteca/pageonex/tree/newbootstrap> to work on
>> this upgrade. You could test this bug only locally for the moment. I might
>> upload it to the dev server <http://dev.pageonex.com/> soon.
>>
>> Thanks,
>> pablo
>>
>> ps. Meanwhile, some months ago we got our peer reviewed paper about
>> PageOneX published. Check it out
>> <http://blog.pageonex.com/2016/05/07/peer-reviewed-paper-about-pageonex-published/>!
>>
>> _______________________________________________
>> Pageonexdev mailing list
>> Pageonexdev at mit.edu
>> http://mailman.mit.edu/mailman/listinfo/pageonexdev
>>
>>
>>
> _______________________________________________
> Pageonexdev mailing list
> Pageonexdev at mit.edu
> http://mailman.mit.edu/mailman/listinfo/pageonexdev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.mit.edu/pipermail/pageonexdev/attachments/20161023/bb669d2d/attachment-0001.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: two-front-pages-in-coding-page.jpg
Type: image/jpeg
Size: 443255 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/pageonexdev/attachments/20161023/bb669d2d/attachment-0001.jpg