[mosh-devel] [PATCH] Make errors from setsockopt( IP_MTU_DISCOVERY ) non-fatal.

[Daniel Thompson]

On August 31, 2016 12:29:01 AM GMT+01:00, John Hood <cgull at glup.org> wrote:
>On 08/30/16 04:28 PM, Daniel Thompson wrote:
>> Currently any failure to set this option cause a fatal exception to
>be
>> thrown. This is odd because the code itself is conditionally
>compiled.
>Thanks!  Windows Subsystem for Linux, right?  We know about that. 

Quite so... and because my preliminary Google search called it Ubuntu for Windows (Canonical) rather than bash on windows (Microsoft) I didn't spot all the existing discussion.

Oops!


>Microsoft's Linux kernel emulation is missing that socket option.  My
>position has been that Microsoft is responsible for a complete
>emulation, and WSL is still in beta.  I may yet relax that position and
>apply a more sophisticated version of this workaround; there've been a
>number of people hitting this.  See
><https://github.com/mobile-shell/mosh/issues/781> for a little more
>discussion and various links.  If this *isn't* WSL, then please tell us
>where the problem *is* cropping up.

Thanks for the info.


>Also, we generally ask that contributors use GitHub to submit code;
>that
>avoids patch hassles, runs submissions through CI and exposes it to
>review better.  (In this case it doesn't matter much, I've got this
>one-liner already sitting in my repo.)

Very sensible.

In that case some humble feedback... I would have made a pull request but after reading the contact section of the website I decided to send a patch instead!


Daniel.

-- 
Sent using a tiny, tiny keyboard. Pleasw excise any spelkinh nistajes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.mit.edu/pipermail/mosh-devel/attachments/20160831/c6aac9bd/attachment.html