[mosh-devel] Missing include for mosh 1.2.3 on Solaris 10 Sparc

[Keith Winstein]

Hello,

Thanks for your patch!

Could you please test the latest git tip (https://github.com/keithw/mosh)? 
We have had a lot of improvements contributed to make things smoother on 
Solaris and AIX -- I think this issue is fixed there already and will be 
in 1.2.4. But please let us know if not.

Best regards,
Keith

On Mon, 28 Jan 2013, Dagobert Michelsen wrote:

> Hi,
>
> I just compiled mosh 1.2.3 on Solaris 10 Sparc with gcc 4.7.2 and got one missing include.
> Apart from that it works fine. If <sys/termio.h> is not included the compilation breaks with
>
>> /opt/csw/bin/g++-4.7 -DHAVE_CONFIG_H -I. -I../..  -I./../statesync -I./../terminal -I./../network -I./../crypto -I../protobufs -I./../util  -D_REENTRANT -I/opt/csw/include   -I/opt/csw/include   -D__aligned__=aligned -I/opt/csw/gxx/include -I/opt/csw/include -Wall  -fno-strict-overflow -D_FORTIFY_SOURCE=2 -fstack-protector-all -Wstack-protector --param ssp-buffer-size=1 -fPIE -fno-default-inline -pipe -O2 -pipe -mcpu=v9 -MT mosh-client.o -MD -MP -MF .deps/mosh-client.Tpo -c -o mosh-client.o mosh-client.cc
>> In file included from mosh-client.cc:45:0:
>> /usr/include/term.h:1060:8: error: field 'Ottyb' has incomplete type
>> /usr/include/term.h:1061:3: error: field 'Nttyb' has incomplete type
>> gmake[3]: *** [mosh-client.o] Error 1
>
>
> Probably the need for <sys/termio.h> should be checked on configure-time after detecting
> the usage of curses.h.
>
>> From 6cd8c0b45a4ae3ebad473ca00156b74cbff8b1a8 Mon Sep 17 00:00:00 2001
>> From: Dagobert Michelsen <dam at opencsw.org>
>> Date: Mon, 28 Jan 2013 09:21:19 +0100
>> Subject: [PATCH] Add missing include
>>
>> ---
>>  src/frontend/mosh-client.cc | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/frontend/mosh-client.cc b/src/frontend/mosh-client.cc
>> index a9644e3..cc9d6a0 100644
>> --- a/src/frontend/mosh-client.cc
>> +++ b/src/frontend/mosh-client.cc
>> @@ -41,6 +41,7 @@
>>  #include "locale_utils.h"
>>
>>  /* these need to be included last because of conflicting defines */
>> +#include <sys/termio.h>
>>  #include <curses.h>
>>  #include <term.h>
>>
>> --
>> 1.8.1
>
>
>
> Best regards
>
>  -- Dago
>
> -- 
> "You don't become great by trying to be great, you become great by wanting to do something,
> and then doing it so hard that you become great in the process." - xkcd #896
>
>
> _______________________________________________
> mosh-devel mailing list
> mosh-devel at mit.edu
> http://mailman.mit.edu/mailman/listinfo/mosh-devel
>