Questions about iter check in profile_iterator()

[Greg Hudson]

On 01/13/2015 01:45 AM, Shawn M Emery wrote:
> We may want to change other functions like krb5_425_conv_principal
> if this is the intended conditional.

That does appear broken, and also appears to be our only use of
profile_iterator() outside of the profile itself.

Prior to 1.10 that code would get a PROF_MAGIC_ITERATOR error from the
invalid call after the final iteration, so it would function even
though it was incorrectly using the interface.  I think it would be
good to restore the 1.9 behavior by adding a null pointer check to the
magic check, but it would also be good to fix krb5_425_conv_principal
to correctly detect the final iteration.