Host-realm pluggable interface project review
ghudson at MIT.EDU
Fri Aug 9 17:01:29 EDT 2013
On 08/09/2013 04:04 PM, Benjamin Kaduk wrote:
> The comment above the typedef for krb5_hostrealm_fini_fn should probably
> indincate that it is mandatory if krb5_hostrealm_init_fn is supplied.
It's still optional if init is supplied, and that's idiomatic for our
newer plugin interfaces. Obviously, if a module supplies init and not
fini, it has no chance to clean up memory allocated by init, but perhaps
it doesn't need to do so.
> I wonder if lib/krb5/os/hostrealm.c:copy_list() would be useful in an
> internal library instead of a file-static routine.
Perhaps, but it's not obvious where to put it.
> It seems like the fallback to referrals in
> krb5_get_fallback_host_realm() could use the k5_make_realmlist() helper
Yes; I will change that.
> I assume you did manual testing of the plugin-ized dns bits, since
> automated testing is infeasible?
No, but I already have a note to do so before pushing this to master.
Thanks for the review.
More information about the krbdev