Patch for Ticket 6344
bwleake at dev-stack.com
Mon Apr 29 22:40:44 EDT 2013
Thanks for the feedback and the pointer to the style checker script,
that really helped with finding style issues. I've pushed a second
commit to that branch that doesn't have any issues with the checking
script, as well as updated the kadmind.rst and krb5kdc.rst files.
Attempting to run `make man` in src/man resulted in several unrelated
.man files being changed. I've held off updating the man pages in
src/man as a result.
Could you elaborate on your concerns for testing the changes? IPv4
localhost addresses seem like a safe assumption, though I could be very
misguided. For example, we might try testing that without the -l
option, the kdc and kadmin daemons respond on 127.0.0., and with "-l
127.0.0.1", the daemons only respond on 127.0.0.1, and not .2.
On 2013-04-29 12:23, Greg Hudson wrote:
> On 04/29/2013 02:13 AM, bwleake wrote:
>> A first
>> draft of the patch is up at github.com/pwillred/krb5, under the
> Thanks! I took a brief look. Can you take a look at:
> and try to get this more in accordance with our C style? The style
> checker script should help.
>> I am somewhat concerned that running two kdc or kadmin daemons
>> concurrently could result in incorrect or undesired behavior.
> This shouldn't be a problem. We already have krb5kdc -w which forks
> multiple KDC processes.
>> Additionally, I'm unsure if this change would need to go through the
>> project planning process for 1.12 or 1.13.
> We don't need a project proposal for something this simple. We will
> need documentation of the new option in
> doc/admin/admin_commands/krb5kdc.rst and kadmind.rst.
> Ordinarily we would require automated tests for a new feature, but
> not sure if we can test this without making assumptions about the
> builder's network configuration.
More information about the krbdev