Project review: response sets

[Danilo Almeida]

Greg,

Ah, thanks for the pointer.  

  src/include/krb5/krb5.hin defines:
    typedef struct krb5_response_set_st krb5_response_set;

  lib/krb5/krb/response_set.c defines:
    struct krb5_response_set_st

I just one comments from that diff:

I do not know what conventions the krb5 code uses wrt "is" queries, but I
would suggest this for clarity:

  s/k5_response_set_empty/k5_response_set_is_empty/

Thanks,
- Danilo

-----Original Message-----
From: Greg Hudson [mailto:ghudson at MIT.EDU] 
Sent: Saturday, July 14, 2012 8:42 AM
To: Danilo Almeida
Cc: krbdev at mit.edu
Subject: Re: Project review: response sets

On 07/14/2012 04:03 AM, Danilo Almeida wrote:
> Where is krb5_response_set defined?

The typedef is in krb5.h using an undefined structure type; the
structure definition is in lib/krb5/krb/response_set.c

There's a candidate implementation of the current design at:

https://github.com/greghudson/krb5/commit/0fe0f203dd7d5891c836aa7b2fecab4fbe
c21dd3