[PATCH] Plugin Interface Change

[Will Fiveash]

On Mon, Oct 03, 2011 at 03:29:16PM -0400, Greg Hudson wrote:
> The two most notable changes:
> 
> * I adjusted the callback style so that in opaque form (as a void *),
> the callback argument is called "arg" and comes first in the callback
> argument list.  Only in typed form in the invoker and callback is it
> called "state".  A side benefit is that we don't need the name
> "newstate" when constructing state structures, since "state" won't
> conflict with the "arg" of the outer callback.

As an aside, having dealt with bugs related to the fact that void *
essentially disables C type checking wouldn't it be better to use a
incomplete struct pointer typedef?

Something like:

struct gss_ctx_id;
typedef struct gss_ctx_id  *gss_ctx_id_t;

instead of:

typedef void *gss_ctx_id_t;

or am I off base?

-- 
Will Fiveash
Oracle
http://opensolaris.org/os/project/kerberos/
Sent using mutt, a sweet, text based e-mail app <http://www.mutt.org/>