RFC: libverto nearing release

Simo Sorce simo at redhat.com
Thu Jun 30 16:12:23 EDT 2011


On Thu, 2011-06-30 at 15:25 -0400, Greg Hudson wrote:
> On Thu, 2011-06-30 at 11:31 -0400, Nathaniel McCallum wrote:
> > The purpose of this email is to let everyone know that libverto is
> > nearing its first release (hopefully today) and I would like to request
> > feedback. The project is hosted here: https://fedorahosted.org/libverto/
> 
> Here are a few things I flagged, mostly cosmetic.
> 
> 1. I couldn't find the git repository from the web site.

I added a link to the main page, here you can find all the git URLs
supported:
http://git.fedorahosted.org/git/?p=libverto.git

> 2. We would prefer not to see camel-case in the type names, as some of
> them will appear in our function signatures.
> 
> 3. We would prefer typedefs for the types in order to reduce the amount
> of horizontal space it takes to add an event context to a function
> signature.  I have a personal preference for typedeffing the pointer
> type for abstract types, so that to the caller it doesn't look like a
> dereferenceable object.

Sorry Greg but this is my fault, I asked Nathaniel not to typedef stuff
because I personally find it hinders readability, for API users,
especially for pointers.
It doesn't matter if it looks dereferenceable to the caller when it is
opaque and therefore you have nothing to dereference, but it tells you
that this is a pointer and not a structure, making APIs more clear on
what they expect from you.
I find particularly annoying when APIs define then mix typedefs to
pointer and non-pointer to the same underlying type, it gives a level of
uncertainty we should really avoid in security related products IMO.

> 4. The documentation of verto_new(NULL) exposes more of the
> implementation than I think is really wise; in particular, promising to
> try to figure out what event libraries you're linked to seems
> over-generous.

It's necessary, you want to use an event library the calling application
is already linked to by default.

> > There are a few known issues. The most important is that libverto has
> > only been tested on Fedora and there will likely be some (hopefully only
> > minor) issues on other platforms.
> 
> When (1) is addressed, I will test the build on Solaris 10.

See above,
Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the krbdev mailing list