[RFC][PATCH] krb5 => libverto main loop

Nathaniel McCallum npmccallum at redhat.com
Tue Aug 23 15:58:10 EDT 2011

Attached is take #2, it should fix all the issues below except where

On Wed, 2011-08-17 at 19:47 -0400, Greg Hudson wrote:
> * Just as a point of information, at some point the code should change
> to not set up the routing socket if IPv4 and IPv6 pktinfo are both
> available.  This is slightly complicated by the new design where
> loop_setup_routing_socket() is a separate call from
> loop_setup_network().  I expect we'll just move udp_flags from a field
> of struct socksetup to a pair of global booleans.

If we make IPv6 non-conditional that should essentially fix this
problem, right?

> * In net-server.c you use a 0-second timeout to emulate an idle event.
> Could this emulation be done inside libverto for back ends which don't
> support idle events?

No, libverto cannot emulate idle since it means something very different
than timeout of 0. This could have very bad effects for someone who asks
for idle and gets timeout instead (imagine 1000 idle events that should
be run gradually when there is nothing else to do, but are instead run
immediately, blocking processing of other requests).

In this case, timeout is acceptable since we just want to finish the
currently processing requests. But in general, timeout cannot emulate

> I'll reiterate the style issues I ran into while reviewing the patch.  I
> mentioned all but the first of these by voice on Tuesday, but I spoke
> kind of quickly at that point:
> * Spaces around binary operators always (except . and ->).
> * No spaces before for-loop semicolons.

I did not see either of these... Perhaps my grep-fu isn't as good as

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-a-loop_-prefix-to-all-the-functions-involving-th.patch
Type: text/x-patch
Size: 9050 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/krbdev/attachments/20110823/fcde603c/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-don-t-log-on-sigpipe-in-the-admin-server.patch
Type: text/x-patch
Size: 2195 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/krbdev/attachments/20110823/fcde603c/attachment-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-remove-purify-support-per-ghudson-s-request.patch
Type: text/x-patch
Size: 3329 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/krbdev/attachments/20110823/fcde603c/attachment-0002.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-remove-reset_db-since-it-is-no-longer-necessary-igno.patch
Type: text/x-patch
Size: 3394 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/krbdev/attachments/20110823/fcde603c/attachment-0003.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-migrate-net-server-loop-to-use-libverto.patch
Type: text/x-patch
Size: 71809 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/krbdev/attachments/20110823/fcde603c/attachment-0004.bin

More information about the krbdev mailing list