svn rev #23845: branches/krb5-1-8/src/lib/krb5/krb/

Love Hörnquist Åstrand lha at kth.se
Mon Mar 29 22:06:55 EDT 2010


That would because its a continue needed flag.

Love


29 mar 2010 kl. 18:51 skrev tlyu at mit.edu:

> http://src.mit.edu/fisheye/changelog/krb5/?cs=23845
> Commit By: tlyu
> Log Message:
> ticket: 6693
> version_fixed: 1.8.1
> status: resolved
> 
> pull up r23844 from trunk
> 
> ------------------------------------------------------------------------
> r23844 | ghudson | 2010-03-29 18:08:21 -0400 (Mon, 29 Mar 2010) | 9 lines
> 
> ticket: 6693
> subject: Fix backwards flag output in krb5_init_creds_step()
> tags: pullup
> target_version: 1.8.1
> 
> krb5_init_creds_step() is taken from Heimdal, which sets *flags to 1
> for "continue" and 0 for "stop".  Unfortunately, we got it backwards
> in 1.8; fix it for 1.8.1.
> 
> 
> Changed Files:
> U   branches/krb5-1-8/src/lib/krb5/krb/get_in_tkt.c
> Modified: branches/krb5-1-8/src/lib/krb5/krb/get_in_tkt.c
> ===================================================================
> --- branches/krb5-1-8/src/lib/krb5/krb/get_in_tkt.c	2010-03-29 22:08:21 UTC (rev 23844)
> +++ branches/krb5-1-8/src/lib/krb5/krb/get_in_tkt.c	2010-03-30 01:51:04 UTC (rev 23845)
> @@ -1083,7 +1083,7 @@
>                                     &flags);
>         if (code == KRB5KRB_ERR_RESPONSE_TOO_BIG && !tcp_only)
>             tcp_only = 1;
> -        else if (code != 0 || (flags & KRB5_INIT_CREDS_STEP_FLAG_COMPLETE))
> +        else if (code != 0 || (flags & 1) == 0)
>             break;
> 
>         krb5_free_data_contents(context, &reply);
> @@ -2065,7 +2065,7 @@
>         }
>     }
> 
> -    *flags = (ctx->flags & KRB5_INIT_CREDS_STEP_FLAG_COMPLETE);
> +    *flags = (ctx->flags & KRB5_INIT_CREDS_STEP_FLAG_COMPLETE) ? 0 : 1;
> 
>     return code;
> }
> 
> _______________________________________________
> cvs-krb5 mailing list
> cvs-krb5 at mit.edu
> https://mailman.mit.edu/mailman/listinfo/cvs-krb5





More information about the krbdev mailing list