Revisiting krb5_gic_opt_ext

[Greg Hudson]

On Wed, 2009-11-25 at 16:58 -0500, Sam Hartman wrote:
> Why does krb5_get_init_creds (the synchronous wrapper) need to call
> opt_to_opte?
> Why not defer opt_to_opte until the init function?

The direct answer is: it receives an already opt_to_opte'd argument.

But the indirect answer is: I don't think any of the callers need to do
that conversion.  So we can change krb5_get_init_creds to accept a
non-opte'd options argument and sidestep the problem by only doing the
conversion once, in krb5_init_creds_init.  No need to alter the
opt_to_opte contract if we do that.

This change is slightly complicated because of all of the compatibility
code which calls krb5_get_init_creds, but I will try to make it work.