Code quality news
Nicolas.Williams at sun.com
Fri Jun 5 12:17:15 EDT 2009
On Fri, Jun 05, 2009 at 02:19:05AM -0400, Ken Raeburn wrote:
> On Jun 4, 2009, at 13:35, ghudson at MIT.EDU wrote:
> > With the krb5 1.7 release out, we have the opportunity to spend a
> > little time on general code quality before getting back into the press
> > of new features and new release-critical bugs. Here is some stuff
> > we've been thinking about in meetings and/or working on:
> Overall this looks very good!
> > 2. Splitting up big source files
> I think this is good to a point. [...]
> I also think it can be reasonable to use preprocessor directives for
> some subsetting. [...]
> > Some of the specialized applications of krb5 involve subsets of the
> > libraries--a well-known example is the kernel krb5 code necessary to
> > support the NFS client and server. Although it's hard to structure
> > the source code to handle every possible subset, it's generally easier
> > to build subsets out of smaller pieces.
> True, though a "piece" could be a function instead of a file.
We've managed this at the file level. Using #ifdefs to achieve the same
effect would be fine too, I think.
More information about the krbdev