Services4User review

[Greg Hudson]

On Mon, 2009-08-24 at 17:14 -0400, Nicolas Williams wrote:
> http://opensolaris.org/os/community/on/
> http://opensolaris.org/os/community/documentation/getting_started_docs/cstyle.ms.pdf
> http://opensolaris.org/os/community/documentation/getting_started_docs/cstyle.ms

The latter two links are coming up not found, as are the links to the C
style guide on the first page.  As for the larger issue of whether to
use the Sun style or the krb5 style for GSSAPI code, I'm about to
discuss that in a meeting and will likely have more to say later.

Regarding bitfields: I was not suggesting using flag fields and bitwise
arithmetic over bitfields.  The previous code just used a pair of ints,
while the new code uses three 1-bit bitfields.  The idea is to sacrifice
a bit of heap space to give the compiler an easier job, not to try to
write better code than the compiler can.  Whether the flags are accessed
on performance-sensitive paths is irrelevant; the concern is code size,
not speed, so the question is how many times the flags are accessed in
the code, not how often at runtime.  Basically, I am questioning whether
this is premature optimization.