merged linux keyring code
kwc at citi.umich.edu
Tue Oct 3 15:08:25 EDT 2006
On 10/3/06, Kevin Coffman <kwc at citi.umich.edu> wrote:
> On 10/3/06, Sam Hartman <hartmans at mit.edu> wrote:
> > >>>>> "Kevin" == Kevin Coffman <kwc at citi.umich.edu> writes:
> > >> Questions:
> > >>
> > >> In start_seq_get, it appears that the iterator will process no
> > >> more than the number of keys that existed when resolve was
> > >> called. (Plus one, potentially, because of the magic entry
> > >> holding the principal name.) Perhaps it should use
> > >> key_read_alloc instead?
> > Kevin> Actually, numkeys is updated in store_cred() and should
> > Kevin> always be up-to-date. I probably could have implemented
> > Kevin> remove_cred() and updated the numkeys count there too, but
> > Kevin> does anything depend on it doing anything?
> > What happens when someone else in another process stores a credential?
> I'll come up with a patch for this...
The attached patch:
- adds a function to get ccache keycount
- uses it in two places
- fixes free problem if next_cred fails
- simplifies the clearcache function by using keyctl_clear()
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4317 bytes
Desc: not available
Url : http://mailman.mit.edu/pipermail/krbdev/attachments/20061003/aef49a41/attachment.bin
More information about the krbdev