local array of structures not declared static

Denis Vlasenko vda at ilport.com.ua
Tue Dec 6 09:27:47 EST 2005


Hi,

krb5-1.4.3/src/lib/kadm5/logger.c:


                       /*
                         * If there is a facility present, then parse that.
                         */
                        if (cp2) {
                            const struct {
                                const char *name;
                                int value;
                            } facilities[] = {
                                { "AUTH",       LOG_AUTH        },
#ifdef  LOG_AUTHPRIV
                                { "AUTHPRIV",   LOG_AUTHPRIV    },
#endif  /* LOG_AUTHPRIV */
#ifdef  LOG_KERN
                                { "KERN",       LOG_KERN        },
#endif  /* LOG_KERN */


Shouldn't we add "static" before "const" here?
--
vda


More information about the krbdev mailing list