[krbdev.mit.edu #9229] git commit

Greg Hudson via RT rt-comment at krbdev.mit.edu
Mon Nov 9 11:56:58 EST 2026


Mon Nov 09 11:56:58 2026: Request 9229 was acted upon.
 Transaction: Ticket created by ghudson at mit.edu
       Queue: krb5
     Subject: git commit
       Owner: ghudson at mit.edu
  Requestors: 
      Status: new
 Ticket <URL: https://krbdev.mit.edu/rt/Ticket/Display.html?id=9229 >



Exclude nested AD-IF-RELEVANT authdata in KDC

When including authdata from a KDC request, the KDC tries to filter
out authdata types that should only originate from KDCs using
is_kdc_issued_authdata().  This check is not strictly necessary for
authdata security and is not a sufficient mechanism for authdata
security by itself (because new KDC-origin-only authdata types can be
added over time), but it can mitigate the impact of some bugs.

When the authdata type is AD-IF-RELEVANT, is_kdc_issued_authdata()
performs minimal decoding on the container, extracting only the
authdata types.  This is good because it limits the amount of KDC time
and memory a client can consume by requesting an authdata element
packed with nested containers.  But it also means we miss KDC-issued
authdata elements within nested AD-IF-RELEVANT containers; such
elements would be found by krb5_find_authdata() so are still operable.

In is_kdc_issued_authdata(), assume that any client-provided authdata
element containing a nested AD-IF-RELEVANT container is nefarious and
filter it out.  Also remove the desired_type parameter as we no longer
need it.

Discovered by Claude and Ada Logics, and by Alejandro Pacheco.  Test
case adapted from a patch by Alejandro Pacheco.

https://github.com/krb5/krb5/commit/e81ea7f9a9c2e04faf5d24452f96a0419a047aac
Author: Greg Hudson <ghudson at mit.edu>
Commit: e81ea7f9a9c2e04faf5d24452f96a0419a047aac
Branch: master
 src/kdc/kdc_authdata.c  | 14 +++++++++-----
 src/tests/t_authdata.py |  8 ++++++++
 2 files changed, 17 insertions(+), 5 deletions(-)



More information about the krb5-bugs mailing list