[krbdev.mit.edu #5841] [Comment] GSSAPI Error Display Bug

[Greg Hudson via RT]

http://kerborg-prod-app-1.mit.edu/rt/Ticket/Display.html?id=5841
This is a comment.  It is not sent to the Requestor(s):

I check the com_err implementations of error_message(), and the in-tree
com_err has masked the incoming error code since 1997
(commit 1eda083efe0b1c9f8db5c559651dbab9ae09faa2), allowing positive values
between 2^31 and 2^32-1 to be decoded as if the corresponding negative value
had been passed.  The e2fsprogs com_err started masking incoming error codes
in 2007 (commit 6b6c27fb8a45f264194d8dd637643d8b4898271a), shortly after this
bug report.

So, it shouldn't be necessary to add a cast to the g_display_com_err_status()
call to error_message(), as that is now handled internally.  I will close this
ticket with no changes.

As aside note, SPNEGO also calls error_message() with an uncasted OM_uint32
value, so if we do ever decide to add a cast to g_display_com_err_status(), we
should add one there as well.