[krbdev.mit.edu #8661] git commit

Erik Sjölund via RT rt-comment at KRBDEV-PROD-APP-1.mit.edu
Tue Apr 24 17:20:34 EDT 2018


A comment regarding the git commit:

https://github.com/krb5/krb5/commit/c5b0a998d6349f8c90821a347db5666aed0e50eb

The check for argc == 0 happens after the first use of argv[0].
Why not place the if statement right in the start of main()?

On Tue, Apr 24, 2018 at 10:10 PM, Greg Hudson via RT
<rt-comment at krbdev.mit.edu> wrote:
>
> Check for zero argc in ksu
>
> Most programs in the tree will perform a null dereference when argc is
> zero, but as a setuid program ksu should be extra careful about memory
> errors, even if this one is harmless.  Check and exit with status 1
> immediately.
>
> https://github.com/krb5/krb5/commit/c5b0a998d6349f8c90821a347db5666aed0e50eb
> Author: Greg Hudson <ghudson at mit.edu>
> Commit: c5b0a998d6349f8c90821a347db5666aed0e50eb
> Branch: master
>  src/clients/ksu/main.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>



More information about the krb5-bugs mailing list