[krbdev.mit.edu #7961] git commit

Greg Hudson via RT rt-comment at krbdev.mit.edu
Tue Jul 8 20:17:07 EDT 2014


Include autoconf.h before system headers

Include autoconf.h (either directly or via proxy) before system
headers, so that feature test macros defined there can affect the
system namespace.  Where include order was changed, eliminate some
redundant or unnecessary includes.

https://github.com/krb5/krb5/commit/02a1123cf44381690c28f18ab2c4ba8036200539
Author: Greg Hudson <ghudson at mit.edu>
Commit: 02a1123cf44381690c28f18ab2c4ba8036200539
Branch: master
 src/appl/gss-sample/gss-misc.c                     |    4 ++--
 src/appl/simple/client/sim_client.c                |   15 +++++----------
 src/appl/user_user/client.c                        |    9 +++------
 src/appl/user_user/server.c                        |   12 +++++-------
 src/clients/kpasswd/kpasswd.c                      |    3 +--
 src/clients/kpasswd/ksetpwd.c                      |    4 +---
 src/clients/ksu/setenv.c                           |    2 +-
 src/clients/ksu/xmalloc.c                          |    3 +--
 src/clients/kswitch/kswitch.c                      |    2 +-
 src/clients/kvno/kvno.c                            |    4 +---
 src/kadmin/cli/keytab.c                            |    5 -----
 src/kadmin/cli/ss_wrapper.c                        |    2 +-
 src/kadmin/dbutil/dump.c                           |    1 -
 src/kadmin/dbutil/kadm5_create.c                   |    5 +----
 src/kadmin/dbutil/kdb5_create.c                    |    1 -
 src/kadmin/dbutil/kdb5_mkey.c                      |    3 +--
 src/kadmin/dbutil/kdb5_util.c                      |    1 -
 src/kadmin/dbutil/ovload.c                         |    8 +-------
 src/kadmin/server/ipropd_svc.c                     |    4 +---
 src/kadmin/server/ovsec_kadmd.c                    |    1 +
 src/kdc/kdc_transit.c                              |    2 --
 src/kdc/main.c                                     |   18 ++++++++----------
 src/lib/crypto/crypto_tests/t_pkcs5.c              |    5 -----
 src/lib/crypto/nss/hash_provider/hash_gen.h        |    2 +-
 src/lib/gssapi/krb5/k5sealiov.c                    |    5 +----
 src/lib/gssapi/krb5/k5sealv3.c                     |    5 +----
 src/lib/gssapi/krb5/k5sealv3iov.c                  |    5 +----
 src/lib/gssapi/krb5/k5unsealiov.c                  |    5 +----
 src/lib/gssapi/krb5/naming_exts.c                  |    4 +---
 src/lib/gssapi/krb5/prf.c                          |    4 +---
 src/lib/gssapi/krb5/store_cred.c                   |    4 +---
 src/lib/gssapi/spnego/spnego_mech.c                |    4 ----
 src/lib/kadm5/alt_prof.c                           |    2 +-
 src/lib/kadm5/chpass_util.c                        |    5 +----
 src/lib/kadm5/clnt/client_init.c                   |   11 +----------
 src/lib/kadm5/srv/server_acl.c                     |    3 +--
 src/lib/kadm5/srv/server_init.c                    |    5 +----
 src/lib/kadm5/srv/server_kdb.c                     |    2 --
 src/lib/kadm5/unit-test/setkey-test.c              |    1 -
 src/lib/kdb/kdb5.c                                 |    3 ---
 src/lib/kdb/kdb5.h                                 |    4 ++--
 src/lib/kdb/kdb_convert.c                          |    3 +--
 src/lib/krb5/krb/appdefault.c                      |    2 --
 src/lib/krb5/krb/bld_princ.c                       |    1 -
 src/lib/krb5/krb/chpw.c                            |    1 -
 src/lib/krb5/krb/deltat.c                          |    3 +--
 src/lib/krb5/krb/get_in_tkt.c                      |    2 --
 src/lib/krb5/krb/kerrs.c                           |    1 -
 src/lib/krb5/krb/t_kerb.c                          |    2 +-
 src/lib/krb5/krb/x-deltat.y                        |    3 +--
 src/lib/krb5/krb5_libinit.c                        |    3 ---
 src/lib/krb5/os/changepw.c                         |    2 +-
 src/lib/krb5/os/locate_kdc.c                       |    3 +--
 src/lib/krb5/os/sendto_kdc.c                       |    2 +-
 src/lib/krb5/os/t_locate_kdc.c                     |    5 ++---
 src/lib/krb5/os/t_std_conf.c                       |    2 +-
 src/lib/krb5/os/t_trace.c                          |    9 ++-------
 src/lib/krb5/rcache/rc_dfl.c                       |    2 +-
 src/lib/krb5/rcache/t_replay.c                     |    5 -----
 src/lib/rpc/auth_unix.c                            |    3 +--
 src/lib/rpc/clnt_generic.c                         |    2 +-
 src/lib/rpc/clnt_perror.c                          |    3 +--
 src/lib/rpc/clnt_simple.c                          |    2 +-
 src/lib/rpc/getrpcport.c                           |    2 +-
 src/lib/rpc/pmap_rmt.c                             |    5 +----
 src/lib/rpc/svc_auth_gss.c                         |    5 +----
 src/lib/rpc/svc_tcp.c                              |    7 +------
 src/lib/rpc/svc_udp.c                              |    6 +-----
 src/lib/rpc/unit-test/client.c                     |    2 +-
 src/plugins/audit/kdc_j_encode.c                   |    2 +-
 src/plugins/authdata/greet_client/greet.c          |    2 --
 src/plugins/authdata/greet_server/greet_auth.c     |    2 --
 src/plugins/kdb/db2/adb_openclose.c                |    2 +-
 src/plugins/kdb/db2/libdb2/btree/bt_open.c         |    4 ++--
 src/plugins/kdb/ldap/ldap_util/kdb5_ldap_policy.c  |    2 --
 src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c   |    1 -
 .../kdb/ldap/ldap_util/kdb5_ldap_services.c        |    1 -
 src/plugins/kdb/ldap/ldap_util/kdb5_ldap_util.c    |    4 +---
 src/plugins/kdb/ldap/libkdb_ldap/kdb_ldap.h        |   12 ++++++------
 src/plugins/kdb/ldap/libkdb_ldap/ldap_misc.c       |    5 ++---
 src/plugins/kdb/ldap/libkdb_ldap/ldap_principal2.c |    2 +-
 .../kdb/ldap/libkdb_ldap/ldap_service_stash.c      |    2 +-
 src/plugins/kdb/ldap/libkdb_ldap/lockout.c         |    3 ---
 src/plugins/preauth/pkinit/pkinit.h                |    3 +--
 src/plugins/preauth/pkinit/pkinit_clnt.c           |   14 ++++----------
 src/plugins/preauth/pkinit/pkinit_crypto_nss.c     |   10 +++++-----
 src/plugins/preauth/pkinit/pkinit_crypto_openssl.c |   11 ++---------
 src/plugins/preauth/pkinit/pkinit_crypto_openssl.h |    4 ++--
 src/plugins/preauth/pkinit/pkinit_kdf_constants.c  |   13 -------------
 src/plugins/preauth/pkinit/pkinit_kdf_test.c       |   11 +----------
 src/plugins/preauth/pkinit/pkinit_lib.c            |   10 ----------
 src/plugins/preauth/pkinit/pkinit_profile.c        |    5 -----
 src/plugins/preauth/pkinit/pkinit_srv.c            |    5 -----
 src/slave/kprop.c                                  |    6 +-----
 src/slave/kprop_sock.c                             |    7 +++----
 src/slave/kpropd.c                                 |   11 ++++-------
 src/slave/kproplog.c                               |    3 +--
 src/tests/asn.1/krb5_decode_leak.c                 |    4 ----
 src/tests/asn.1/krb5_encode_test.c                 |    1 -
 src/tests/asn.1/utility.h                          |    2 +-
 src/tests/gss-threads/gss-client.c                 |    6 +-----
 src/tests/gss-threads/gss-misc.c                   |    2 +-
 src/tests/gss-threads/gss-server.c                 |    2 +-
 src/tests/gssapi/t_enctypes.c                      |    3 ---
 src/tests/hammer/kdc5_hammer.c                     |    4 +---
 src/tests/misc/test_getsockname.c                  |    2 +-
 src/tests/resolve/addrinfo-test.c                  |    6 +-----
 src/tests/responder.c                              |    6 ++----
 src/tests/shlib/t_loader.c                         |    6 +-----
 src/tests/threads/init_ctx.c                       |    8 +-------
 src/tests/threads/profread.c                       |    8 +-------
 src/tests/threads/t_rcache.c                       |    4 +---
 src/util/et/error_message.c                        |    8 +-------
 src/util/et/test_et.c                              |    2 +-
 src/util/profile/prof_int.h                        |    8 ++++----
 src/util/ss/error.c                                |    6 ++----
 src/util/ss/ss_internal.h                          |    9 +--------
 src/util/support/cache-addrinfo.h                  |    5 ++---
 src/util/support/errors.c                          |    7 +------
 src/util/support/fake-addrinfo.c                   |    7 ++-----
 src/util/support/gmt_mktime.c                      |    2 +-
 src/util/support/init-addrinfo.c                   |    7 ++-----
 src/util/support/plugins.c                         |    7 +------
 src/util/support/t_unal.c                          |    1 -
 src/util/support/threads.c                         |    5 +----
 src/util/support/utf8_conv.c                       |    1 -
 src/util/verto/verto-k5ev.c                        |    2 +-
 127 files changed, 145 insertions(+), 429 deletions(-)



More information about the krb5-bugs mailing list