[krbdev.mit.edu #7760] [PATCH] Don't assume function arguments are evaluated right-to-left

[Mark H Weaver via RT]

"Greg Hudson via RT" <rt-comment at krbdev.mit.edu> writes:

> This was fixed on master in commit 
> 525eafc83a0fbe8f215b7749b5774d54468a19d1 (March 2013).

If the problem was fixed in March, why is the bug still present in
1.11.4, released a few days ago?

> Unless it is causing a build failure, I don't think there is a need to
> backport the fix to prior releases since the bug is in a test program.

It _does_ cause a build failure, because you pass options to GCC that
turn that warning into a fatal error.

> I don't think any argument evaluation order would make the old code 
> correct; it was a straightforward case of use before initialization.

Fair enough.  My hope was that if 'krb5_init_context' reported an error,
it would have partially initialized 'context', enough for 'bail_on_err'
to work properly.  Admittedly, I didn't not investigate whether this
hope was justified.

In any case, without my patch 1.11.4 fails to build at all on my system.
With the patch, it builds and passes the test suite.

    Regards,
      Mark