[krbdev.mit.edu #7545] SVN Commit

Tom Yu via RT rt-comment at krbdev.mit.edu
Fri Jan 11 16:04:05 EST 2013


Fix various integer issues

In kdc_util.c and spnego_mech.c, error returns from ASN.1 length
functions could be ignored because they were assigned to unsigned
values.  In spnego_mech.c, two buffer size checks could be rewritten
to reduce the likelihood of pointer overflow.  In dump.c and
kdc_preauth.c, calloc() could be used to simplify the code and avoid
multiplication overflow.  In pkinit_clnt.c, the wrong value was
checked for a null result from malloc(), and the code could be
simplified.

Reported by Nickolai Zeldovich <nickolai at csail.mit.edu>.

(cherry picked from commit d3c5450ddf0b20855e86dab41735d56c6860156b)

[tlyu at mit.edu: omitted pkinit and kdb5_util fixes because they're not
conservative]

https://github.com/krb5/krb5/commit/8e31374995eaa4515323e56d1579ee7ad0ebc4ca
Author: Tom Yu <tlyu at mit.edu>
Commit: 8e31374995eaa4515323e56d1579ee7ad0ebc4ca
Branch: krb5-1.10
 src/kdc/kdc_preauth.c               |    3 +--
 src/kdc/kdc_util.c                  |    3 ++-
 src/lib/gssapi/spnego/spnego_mech.c |    6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)



More information about the krb5-bugs mailing list