[krbdev.mit.edu #7368] MAX_ULOGENTRIES is too low

Nico Williams via RT rt-comment at krbdev.mit.edu
Tue Sep 25 17:15:23 EDT 2012


There's no reason to have a maximum on the number of entries
in the iprop ulog.  This should just be removed.


diff --git a/src/include/kdb_log.h b/src/include/kdb_log.h
index beecdc1..c8d0288 100644
--- a/src/include/kdb_log.h
+++ b/src/include/kdb_log.h
@@ -53,7 +53,6 @@ extern "C" {
 /*
  * Default ulog file attributes
  */
-#define MAX_ULOGENTRIES 2500
 #define DEF_ULOGENTRIES 1000
 #define ULOG_IDLE_TIME  10              /* in seconds */
 /*
diff --git a/src/lib/kadm5/alt_prof.c b/src/lib/kadm5/alt_prof.c
index d218640..b18bbd5 100644
--- a/src/lib/kadm5/alt_prof.c
+++ b/src/lib/kadm5/alt_prof.c
@@ -822,9 +822,7 @@ krb5_error_code kadm5_get_config_params(context,
use_kdc_config,
     } else {
         if (aprofile && !krb5_aprof_get_int32(aprofile, hierarchy,
                                               TRUE, &ivalue)) {
-            if (ivalue > MAX_ULOGENTRIES)
-                params.iprop_ulogsize = MAX_ULOGENTRIES;
-            else if (ivalue <= 0)
+            if (ivalue <= 0)
                 params.iprop_ulogsize = DEF_ULOGENTRIES;
             else
                 params.iprop_ulogsize = ivalue;



More information about the krb5-bugs mailing list