[krbdev.mit.edu #7371] SVN Commit

Greg Hudson via RT rt-comment at krbdev.mit.edu
Fri Oct 5 14:09:07 EDT 2012


Use a single global dump for iprop full syncs

Use a global dump (the default dump file) for full syncs for iprop.
When a slave asks for a fullsync we kprop the existing global dump to it
if that is good enough, else we dump the DB and send the new global
dump.

Before this change kadmind would run kdb5_util dump -i... each time a
slave asked for a full dump.  This was done in a sub-process,
thankfully, but it was still a waste of time and storage (e.g., if one
has a huge KDB).

Also, long dump times might cause a slave to give up (the timeout for
this is now configurable).  But since iprop dumps bear a serial number
and timestamp and since slaves will resync from that point forward, it
doesn't matter if the dump we send a slave is fresh as long as it is
fresh enough (i.e., that its sno and timestamp are in the ulog).

Also:

 - Rename dumps into place instead of unlink, create, write (but we
   still keep the dump ok files as lock files and as a method of
   signaling to kprop that the dump is complete).

https://github.com/krb5/krb5/commit/4fd4144b3222b060f3e9928a9cb4587df9979539
Author: Nicolas Williams <nico at cryptonector.com>
Committer: Greg Hudson <ghudson at mit.edu>
Commit: 4fd4144b3222b060f3e9928a9cb4587df9979539
Branch: master
 src/include/kdb_log.h          |    2 +
 src/kadmin/dbutil/dump.c       |  231 ++++++++++++++++++++++++++++++---------
 src/kadmin/server/ipropd_svc.c |   68 ++++++------
 src/lib/kdb/kdb_log.c          |    2 +-
 src/lib/kdb/libkdb5.exports    |    1 +
 5 files changed, 215 insertions(+), 89 deletions(-)



More information about the krb5-bugs mailing list