[krbdev.mit.edu #6915] klist -s trips over referral entries

[The RT System itself via RT]

>From krb5-bugs-incoming-bounces at PCH.mit.edu  Wed May 25 15:49:44 2011
Return-Path: <krb5-bugs-incoming-bounces at PCH.mit.edu>
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90])
	by krbdev.mit.edu (Postfix) with ESMTP id 4965A3E711;
	Wed, 25 May 2011 15:49:44 -0400 (EDT)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id p4PJnip3023346;
	Wed, 25 May 2011 15:49:44 -0400
Received: from mailhub-dmz-2.mit.edu (MAILHUB-DMZ-2.MIT.EDU [18.7.62.37])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id p4PEkPhs005026
	for <krb5-bugs-incoming at PCH.mit.edu>; Wed, 25 May 2011 10:46:25 -0400
Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU
	[18.7.68.35])
	by mailhub-dmz-2.mit.edu (8.13.8/8.9.2) with ESMTP id p4PEkJkn011660
	for <krb5-bugs at mit.edu>; Wed, 25 May 2011 10:46:25 -0400
X-AuditID: 12074423-b7babae000007c6b-d3-4ddd163ac193
Authentication-Results: symauth.service.identifier; spf=pass; senderid=pass
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
	by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP
	id 9C.72.31851.A361DDD4; Wed, 25 May 2011 10:46:18 -0400 (EDT)
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4PEkN17015675
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <krb5-bugs at mit.edu>; Wed, 25 May 2011 10:46:24 -0400
Received: from blade.bos.redhat.com (blade.bos.redhat.com [10.16.19.220])
	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id p4PEkMSi020008
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <krb5-bugs at mit.edu>; Wed, 25 May 2011 10:46:23 -0400
Received: from blade.bos.redhat.com (localhost.localdomain [127.0.0.1])
	by blade.bos.redhat.com (8.14.4/8.14.3) with ESMTP id p4PEkaUC031221
	for <krb5-bugs at mit.edu>; Wed, 25 May 2011 10:46:36 -0400
Received: (from nalin at localhost)
	by blade.bos.redhat.com (8.14.4/8.14.4/Submit) id p4PEkaQo031220;
	Wed, 25 May 2011 10:46:36 -0400
Date: Wed, 25 May 2011 10:46:36 -0400
Message-Id: <201105251446.p4PEkaQo031220 at blade.bos.redhat.com>
To: krb5-bugs at mit.edu
Subject: klist -s trips over referral entries
From: nalin at redhat.com
X-send-pr-version: 3.99
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOIsWRWlGSWpSXmKPExsVysWW7jK6V2F1fg5u3tSwaHh5nd2D0aDpz
	lDmAMYrLJiU1J7MstUjfLoErY9eVeSwFH7gqWu62MjUwHuHoYuTkkBAwkZj15yoTiM0o4C3x
	5upxdoi4mMSFe+vZuhi5OIQETjBKtGw9ygzhbGKSmL9zM1RmKZNEX9crFgjnJKPE8vW3WSGc
	NkaJTWtWsYAMYxFQlbjYtJsVxOYVsJNY3jQFLC4iICrx8u8xMFtYQFeia0Y3I4jNBrT8xrxT
	YPVCAlIS7Zems4HYzAIsEn/ebGCBOFBcYsf201DHakscbl7EOoFRcAEjwypG2ZTcKt3cxMyc
	4tRk3eLkxLy81CJdM73czBK91JTSTYzAUBNid1HewfjnoNIhRgEORiUe3i2Xb/sKsSaWFVfm
	HmKU5GBSEuX1F73rK8SXlJ9SmZFYnBFfVJqTWnyIUYKDWUmEt4kFKMebklhZlVqUD5OS5mBR
	EuedK6nuKySQnliSmp2aWpBaBJNl4mA/xCjDwaEkwXsKZLJgUWp6akVaZk4JshpOEMEFsoYH
	aM0bkELe4oLE3OLMdIiiU4yKUuK810ASAiCJjNI8uAGg9FD/////S4yyUsK8jAwMDEI8QBcA
	PY6QB6WXV4ziQE8L8+4EmcKTmVcCN/0V0GImoMUSf2+CLC5JREhJNTAeKr2wXmyrTc5cxvrP
	sv8UhHS5l2bv+rZsa8a/m18u5iz2fzTtLidv3ys2+28dLhe23b4iHdTh1Zz4yX+JwfmPy0yd
	FTevau3zYhaN/nNK/qp2yMHk6qOC9Syr8s/lhF4I5Nm0cHvy2xuPljUdFn8ieNb8bcmsFZp/
	Jfa5zRH9o7LRs42h+sJBJZbijERDLeai4kQA9H0o2AoDAAA=
X-Mailman-Approved-At: Wed, 25 May 2011 15:49:42 -0400
X-BeenThere: krb5-bugs-incoming at mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Reply-To: nalin at redhat.com
Sender: krb5-bugs-incoming-bounces at PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces at PCH.mit.edu


>Submitter-Id:	net
>Originator:	Nalin Dahyabhai
>Organization:
>Confidential:	no
>Synopsis:	klist -s trips over referral entries
>Severity:	non-critical
>Priority:	low
>Category:	krb5-clients
>Class:		sw-bug
>Release:	1.9.1
>Environment:
	
System: Linux blade.bos.redhat.com 2.6.38.6-27.fc15.x86_64 #1 SMP Sun May 15 17:23:28 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux
Architecture: x86_64

>Description:
	Sheldon Hearn reported that 'klist -s' would segfault when the
	user's TGT has expired.  It turns out that referral entries, which
	don't include a realm component, aren't accounted for.
>How-To-Repeat:
	kinit -l 60s
	kvno -C host/foo.example.com@
	sleep 60
	klist -s
>Fix:
	Have klist skip entries that don't include a realm component in the
	server name:

Index: src/clients/klist/klist.c
===================================================================
--- src/clients/klist/klist.c	(revision 24943)
+++ src/clients/klist/klist.c	(working copy)
@@ -386,6 +386,7 @@
             continue;
         if (status_only) {
             if (exit_status && creds.server->length == 2 &&
+                creds.server->realm.length > 0 &&
                 strcmp(creds.server->realm.data, princ->realm.data) == 0 &&
                 strcmp((char *)creds.server->data[0].data, "krbtgt") == 0 &&
                 strcmp((char *)creds.server->data[1].data,