[krbdev.mit.edu #6753] SVN Commit

Greg Hudson via RT rt-comment at krbdev.mit.edu
Mon Jul 26 14:18:58 EDT 2010


Our ancient RPC value internally decodes 32-bit wire values into a
signed long, which is then casted to the appropriate type.
xdr_u_int() contains a check intended to catch wire values that don't
fit into a u_int on platforms with 16-ints, but on platforms with
64-bit longs it was failing on values of 2^31 or larger because the
sign-extended value appeared larger than UINT_MAX.  Fix the check by
casting the value to uint32_t before comparing.

This bug, in combination with a poor choice of types in
kadm_rpc_xdr.c's xdr_krb5_enctype(), prevented negative enctype values
from being transported properly in kadmin's change_password command
result.


http://src.mit.edu/fisheye/changelog/krb5/?cs=24210
Commit By: ghudson
Revision: 24210
Changed Files:
U   trunk/src/lib/rpc/xdr.c




More information about the krb5-bugs mailing list