[krbdev.mit.edu #6519] krb5_copy_error_message() calls krb5int_clear_error() incorrectly

[The RT System itself via RT]

>From krb5-bugs-incoming-bounces at PCH.mit.edu  Fri Jun 26 21:48:47 2009
Return-Path: <krb5-bugs-incoming-bounces at PCH.mit.edu>
X-Original-To: krb5-send-pr-nospam1 at krbdev.mit.edu
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90])
	by krbdev.mit.edu (Postfix) with ESMTP id E93CECCEF8;
	Fri, 26 Jun 2009 21:48:46 +0000 (UTC)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id n5QLmke1030478;
	Fri, 26 Jun 2009 17:48:46 -0400
Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU
	[18.7.21.83])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id n5QLYRat027700
	for <krb5-bugs-incoming at PCH.mit.edu>; Fri, 26 Jun 2009 17:34:27 -0400
Received: from mit.edu (W92-130-BARRACUDA-3.MIT.EDU [18.7.21.224])
	by pacific-carrier-annex.mit.edu (8.13.6/8.9.2) with ESMTP id
	n5QLYNZE005933
	for <krb5-bugs at mit.edu>; Fri, 26 Jun 2009 17:34:24 -0400 (EDT)
Received: from mx1.redhat.com (localhost [127.0.0.1])
	by mit.edu (Spam Firewall) with ESMTP id 7EBB91578BEA
	for <krb5-bugs at mit.edu>; Fri, 26 Jun 2009 17:34:23 -0400 (EDT)
Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by mit.edu with
	ESMTP id B1Dq9PHFW5PgpBdu for <krb5-bugs at mit.edu>;
	Fri, 26 Jun 2009 17:34:23 -0400 (EDT)
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n5QLYNw6005448
	for <krb5-bugs at mit.edu>; Fri, 26 Jun 2009 17:34:23 -0400
Received: from blade.bos.redhat.com (blade.bos.redhat.com [10.16.0.23])
	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5QLYMNR011620
	for <krb5-bugs at mit.edu>; Fri, 26 Jun 2009 17:34:22 -0400
Received: from blade.bos.redhat.com (localhost.localdomain [127.0.0.1])
	by blade.bos.redhat.com (8.14.3/8.14.2) with ESMTP id n5QLYMIa019356
	for <krb5-bugs at mit.edu>; Fri, 26 Jun 2009 17:34:22 -0400
Received: (from nalin at localhost)
	by blade.bos.redhat.com (8.14.3/8.14.3/Submit) id n5QLYMoW019352;
	Fri, 26 Jun 2009 17:34:22 -0400
Date: Fri, 26 Jun 2009 17:34:22 -0400
Message-Id: <200906262134.n5QLYMoW019352 at blade.bos.redhat.com>
To: krb5-bugs at mit.edu
Subject: krb5_copy_error_message() calls krb5int_clear_error() incorrectly
From: nalin at redhat.com
X-send-pr-version: 3.99
X-Scanned-By: MIMEDefang 2.42
X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254
X-Spam-Score: 0.55
X-Spam-Flag: NO
X-Mailman-Approved-At: Fri, 26 Jun 2009 17:48:44 -0400
X-BeenThere: krb5-bugs-incoming at mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Reply-To: nalin at redhat.com
Sender: krb5-bugs-incoming-bounces at PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces at PCH.mit.edu


>Submitter-Id:	net
>Originator:	
>Organization:
>Confidential:	no
>Synopsis:	krb5_copy_error_message() calls krb5int_clear_error() incorrectly
>Severity:	non-critical
>Priority:	medium
>Category:	krb5-libs
>Class:		sw-bug
>Release:	1.7
>Environment:
	
System: Linux blade.bos.redhat.com 2.6.29.4-167.fc11.x86_64 #1 SMP Wed May 27 17:27:08 EDT 2009 x86_64 x86_64 x86_64 GNU/Linux
Architecture: x86_64

>Description:
	When krb5_copy_error_message() calls krb5int_clear_error(), it
	passes it the entire destination context instead of the relevant
	field in the structure.
>Fix:
	Here's the trivial fix:
Index: src/lib/krb5/krb/kerrs.c
===================================================================
--- src/lib/krb5/krb/kerrs.c	(revision 22423)
+++ src/lib/krb5/krb/kerrs.c	(working copy)
@@ -108,7 +108,7 @@
 	krb5int_set_error(&dest_ctx->err, src_ctx->err.code, "%s",
 			  src_ctx->err.msg);
     } else {
-	krb5int_clear_error(dest_ctx);
+	krb5int_clear_error(&dest_ctx->err);
     }
 }